[HOLD for payment 2023-07-14] [$1000] Placeholder not moving back to it's place after selecting a contact

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB
2. Click on "Split bill"
3. Type an email and select the contact that shows up in the below suggestion
4. Notice the placeholder text "Name, email or phone number"

Expected Result:

The placeholder text should return back to it's place after user selects on a contact

Actual Result:

Placeholder stays in typing state and doesn't return back

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.16.3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/9f767ec5-2b7d-4295-9d53-cd50a5e1f51f

https://github.com/Expensify/App/assets/43996225/802d475f-c737-4743-b533-30b44ccff1ec

Expensify/Expensify Issue URL: Issue reported by: @nathan-mulugeta Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684261779675679

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0196a89d054bb9c9e0
• Upwork Job ID: 1660771960364109824
• Last Price Increase: 2023-06-12

[alexpensify]

Waiting for a review here before assigning it out.

[alexpensify]

No update yet

[tylerkaraszewski]

Sorry about all the delays on this. Assigned now.

[melvin-bot[bot]]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

📣 @dukenv0307 You have been assigned to this job by @alexpensify! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[alexpensify]

There we go, automation is in place now! @dukenv0307 the issue has been assigned to you.

[dukenv0307]

Hi @sobitneupane The PR is ready for review https://github.com/Expensify/App/pull/20736

[sobitneupane]

We are having discussion on expected behavior on selecting and unselecting row on New Group and Split Bill pages. So, putting hold on PR.

[alexpensify]

@sobitneupane should we put this GH on hold too?

[alexpensify]

@isabelastisser - I'm going to reassign another bug team member, I'm going OOO until Monday, July 10. I see you are returning on July 5.

Required action from the 🐛 team: Check on the PR state and put it on Hold if we need more time. Maybe move to weekly.

[sobitneupane]

should we put this GH on hold too?

@alexpensify I don't think that will be necessary. I believe we will come to conclusion within a day or two.

[alexpensify]

Thank you for clarifying @sobitneupane!

@isabelastisser when you return, please check the PR state. You can disregard my weekly comment.

[melvin-bot[bot]]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tylerkaraszewski]

Hey @arosiclair - I am leaving on sabbatical so you got picked to take over this issue. I think I'll you'll need to do is review the final PR when it's ready.

[arosiclair]

@sobitneupane what's the status of this issue?

[dukenv0307]

@arosiclair Discussing in the PR, we will try to done soon

[sobitneupane]

PR is off hold now. Decision was made in the thread to highlight text on selecting/deselecting row.

[melvin-bot[bot]]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @dukenv0307 got assigned: 2023-06-27 20:11:23 Z
• when the PR got merged: 2023-07-05 14:31:29 UTC
• days elapsed: 5

On to the next one 🚀

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[isabelastisser]

I'm back. Thanks @alexpensify!

[isabelastisser]

@dukenv0307 @sobitneupane did this PR cause a regression?

[sobitneupane]

Nope @isabelastisser The linked issue is not a bug. It is an expected behavior to focus the textinput on selecting/unselecting row.

[dukenv0307]

I think we are eligible for the timeline bonus because this issue is on hold from Jun 29 to Jul 4

[isabelastisser]

@sobitneupane, to confirm, the PR didn't cause a regression, and this issue is ready for payment, correct?

@arosiclair I think we can process the bonus because the PR merged shortly after it was no longer on hold. Do you agree?

[sobitneupane]

@isabelastisser Yup. The PR didn't cause a regression. The PR has not hit the production yet. So, not ready to issue payment.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.37-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/20736

If no regressions arise, payment will be issued on 2023-07-14. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@sobitneupane] Determine if we should create a regression test for this bug.
• [ ] [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [x] [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[arosiclair]

@arosiclair I think we can process the bonus because the PR merged shortly after it was no longer on hold. Do you agree?

That makes sense to me 👍

[isabelastisser]

I was OOO yesterday and will take care of this by EOD.

[isabelastisser]

@sobitneupane please complete the BugZero checklist.

I will process the payments in Upwork now.

[sobitneupane]

Sorry for the delay @isabelastisser. I will complete the checklist by tomorrow. I will be paid through newDot.

[isabelastisser]

The payments were made in Upwork. Waiting for @sobitneupane to complete the BZ checklist, then we are all set.

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Rather than a bug, it was an inconsistency issue. The PR raised make MoneyRequestParticipantsSplitSelector page consistent with NewGroupPage.

[sobitneupane]

Regression Test Proposal

• Click on FAB
• Click on "Split bill"
• Type an email and select the contact that shows up in the below suggestion
• Verify that the search input is highlighted/selected after user selects/deselects

Do we agree 👍 or 👎

[isabelastisser]

[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

https://github.com/Expensify/Expensify/issues/302474

all set!

[sobitneupane]

https://github.com/Expensify/App/issues/19231#issuecomment-1625449536

Requested payment on newDot.

[JmillsExpensify]

@isabelastisser Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @sobitneupane's NewDot payments. More information on this compliance process in Slack.

[isabelastisser]

Payments summary:

Issue reported by: @Nathan-Mulugeta $250 C+ review: @sobitneupane $1000 review, $500 urgency bonus Issue fixed by: @dukenv0307, $1000 for accepted proposal, $500 urgency bonus

[JmillsExpensify]

Reviewed details for @sobitneupane. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.