Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.49k stars 2.84k forks source link

[HOLD for payment 2023-06-28] [HOLD for payment 2023-06-23] [$1000] Cursor does not change to I beam on selecting mentions like it does for other clickable links #19303

Closed kavimuru closed 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Send message with mention
  4. Click and drag to highlight the message containing the message and observe that cursor remains pointer while highlighting and does not change to I beam

Expected Result:

App should change the cursor to I beam while highlighting the mentions part in message as it normally does for email, links etc

Actual Result:

App keeps the cursor as pointer and does not change to I beam while selecting mentions part in message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.16-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/6d62ab42-d41c-402c-bdb2-7c7dc0898873

https://github.com/Expensify/App/assets/43996225/7113a7bb-9caa-4aa3-8837-78aa5d0affa7

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684312696564409

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017477dd353ae7b577
  • Upwork Job ID: 1664022662379630592
  • Last Price Increase: 2023-06-07
melvin-bot[bot] commented 1 year ago

@JmillsExpensify, @eVoloshchak, @joelbettner, @tienifr Huh... This is 4 days overdue. Who can take care of this?

JmillsExpensify commented 1 year ago

@eVoloshchak Did you request payment via New Expensify? Everyone else has been paid out at this point.

eVoloshchak commented 1 year ago

@JmillsExpensify, yes, requested the payment for this. It should arrive on Jul 6

eVoloshchak commented 1 year ago

Just realized we can close this, since the payment has been released already

eVoloshchak commented 1 year ago

@JmillsExpensify, this has been paid out and can be closed

joelbettner commented 1 year ago

I'm going to close this issue.