Closed kavimuru closed 1 year ago
Triggered auto assignment to @sonialiap (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are β
)ReportActionItemReactions
On ReportActionItem.js
on we need to wrap with a <ReportActionItemThread>
with the same <View>
with styling used of <ReportActionItemReactions>
which is this.props.draftMessage ? styles.chatItemReactionsDraftRight : {}
We can also pass draft props to <ReportActionItemThread>
and handle style there
Job added to Upwork: https://www.upwork.com/jobs/~0145a755aa7c56d944
Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External
)
Triggered auto assignment to @MonilBhavsar (External
), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Reply text is not correctly aligned to the reaction emoji
Currently the ReportActionItemThread
component has maxWidth of 100%
which will fill the entire width, initially when the avatar on the ReportItem is visible it is aligned to the emoji, but when we edit the message the avatar will not be visible then the ReportActionItemThread
will take the whole width
We should wrap the ReportActionItemThread
component with <View style={this.props.draftMessage ? styles.chatItemReactionsDraftRight : {}}>
to align the component correctly when the user is editing the message.
we are currently using this for ReportActionItemReactions
here:
Additionally instead of repeating the code we can wrap both components with the view and put the conditions inside like this
Result:
https://github.com/Expensify/App/assets/75031127/14ab3f63-013a-413e-87ed-7765a43557f8
Couple of proposals are there, @eVoloshchak if you could please take a look
@dhairyasenjaliya's proposal looks good to me. This is a pretty straight-forward fix, looks like this was just missed during the initial implementation
πππ C+ reviewed! cc: @MonilBhavsar
Thanks! Looks good to me too
π£ @dhairyasenjaliya You have been assigned to this job by @MonilBhavsar! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
@MonilBhavsar @eVoloshchak PR ready for review
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.24-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-13. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
bump @sonialiap for the Upwork contract
Will finish up the checklist items tomorrow
@dhanashree-sawant offer sent for reporting issue - paid @dhairyasenjaliya offer sent for fix (bonus will be applied for 3 day merge) - paid @eVoloshchak offer ~pending checklist step completion~ sent for review (bonus will be applied for 3 day merge) - paid
@sonialiap accepted thnx
Thanks @sonialiap, I have accepted the offer.
The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/18274
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18274/files#r1232363177
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is a visual bug, I don't think there is an additional discussion needed
Determine if we should create a regression test for this bug. Is it easy to test for this bug? Yes Is the bug related to an important user flow? Yes Is it an impactful bug? No It's not an impactful bug, but it's one of the most user-facing pages of the app and it's very easy to test, so I think regression test is worth having here.
Regression Test Proposal
Do we agree π or π
Thanks @eVoloshchak! Offer sent, bonus will be added once offer is accepted
Everyone has been paid
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
App should align '1 Reply' text to start of composer on edit as it does for reaction emoji
Actual Result:
App does not align '1 Reply' text to start of composer on edit of message as it does for reaction emoji
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.16.6 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/1f08b2b1-80a0-42df-be82-3cf80fd38e1f
Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684486648715929
View all open jobs on GitHub
Upwork Automation - Do Not Edit