Chat - Extra space is missing on Android app and mWeb if selected from emojis picker

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR https://github.com/Expensify/App/pull/19304

Action Performed:

1. Login to NewDot
2. open any chat
3. Tap on compose box
4. Select an emoji from emoji picker

Expected Result:

Extra space should appear after emoji

Actual Result:

Extra space is missing on Android app and mWeb if selected from emojis picker

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [ ] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.18.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/5e94b19fcac35462b2065357736d0c7a50a46b9fda23459b156b7f46ea873905

https://platform.applause.com/services/links/v1/external/47810df62211054bc27b23f3addf325f865b627985c31fa82ca7a2467f49f2e1

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[AlexanderDmitriev]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Extra space is missing on Android app and mWeb if selected from emojis picker

What is the root cause of that problem?

It was inserting space after picked emoji when click one emoji from suggested emojis. https://github.com/Expensify/App/blob/fe67d69c9043734486c6a639a0d3ba66d5440a04/src/pages/home/report/ReportActionCompose.js#L623

What changes do you think we should make in order to solve the problem?

Remove the space from the line

    this.updateComment(`${commentBeforeColon}${emojiCode}${this.trimLeadingSpace(commentAfterColonWithEmojiNameRemoved)}`, true);

What alternative solutions did you explore? (Optional)

N/A

[tienifr]

This is not a bug but intentional as per this thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1668009281985659?thread_ts=1667208968.300839&cid=C01GTK53T8Q

[joekaufmanexpensify]

Yep, closing as this is intentional, per the above thread!