Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

[LOW] [P2P] Allow for QR codes to be easily saved or copied on all platforms #19834

Open MitchExpensify opened 1 year ago

MitchExpensify commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

On desktop:

  1. Click any room header
  2. Click "Share code"
  3. Right click the QR code

Expected Result:

Have the option to "Save image as", "Copy image", or Download the QR code image

Actual Result:

No option to easily save or copy the QR code image

Workaround:

Copy or save the QR code image on mobile

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.19-7 Reproducible in staging?: Yes Reproducible in production?: Yes Email or phone of affected tester (no customers): All Notes/Photos/Videos:

image image

Expensify/Expensify Issue URL: Issue reported by: @MitchExpensify Slack conversation: Internal convo: https://expensify.slack.com/archives/C03U7DCU4/p1685041725518029, #bug-zero convo tbd

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013d2f9dd751374d8e
  • Upwork Job ID: 1663602988972146688
  • Last Price Increase: 2023-05-30
robertjchen commented 1 year ago

Yep, check the issue # from my comment here: https://github.com/Expensify/App/issues/19834#issuecomment-1682028722

greg-schroeder commented 1 year ago

Where do we stand here @robertjchen? <3

shawnborton commented 1 year ago

What's the latest here?

robertjchen commented 1 year ago

Getting backend changes reviewed while we're all here during Offshore.

greg-schroeder commented 1 year ago

Progress continues

greg-schroeder commented 1 year ago

Offshore is over! Thoughts on this one @robertjchen?

robertjchen commented 1 year ago

Got the green light 🟢 for the backend changes- going to do it later this week when things are more stable 🤞

robertjchen commented 1 year ago

site stability issues last week, this week is the week?

greg-schroeder commented 1 year ago

Maybe this week's the week? :) @robertjchen

robertjchen commented 1 year ago

two fires so far, hoping not to add gasoline to it 😄

robertjchen commented 1 year ago

Moving to Monthly for proper expectations

greg-schroeder commented 1 year ago

Seems like no update here

greg-schroeder commented 11 months ago

Same as above

greg-schroeder commented 11 months ago

@robertjchen would you say this fits into a current wave or VIP? If not and there hasn't been any more progress, perhaps this can be closed.

robertjchen commented 11 months ago

This still needs to be done- the final steps should be pretty straightforward. We can file it under VIP starting next year if it's not completed before then 👍

arielgreen commented 10 months ago

Adding this to the Group release under #vip-splits.

Christinadobrzyn commented 10 months ago

I'm closing this GH as a dupe of this issue. Feel free to let me know if you think they need to be treated separately.

greg-schroeder commented 10 months ago

This has been sitting forever - sounds like we classified it as a nice to have? Should this still be listed as Critical or even open at all?

robertjchen commented 10 months ago

Changed to Low - P2P per https://expensify.slack.com/archives/C05RECHFBEW/p1705954738163119?thread_ts=1705712907.222529&cid=C05RECHFBEW

robertjchen commented 10 months ago

Also updating assignments for cleaner K2s and since this is now an Internal task.

robertjchen commented 8 months ago

Now prioritized under #vip-split

robertjchen commented 8 months ago

Revisiting this later this week!

robertjchen commented 7 months ago

Was focused on pushing out wave items, revisiting this this week for sure!

robertjchen commented 7 months ago

Tackling this week, moved https://github.com/Expensify/Expensify/issues/300566 to weekly

robertjchen commented 6 months ago

https://github.com/Expensify/Expensify/issues/300566 to be addressed first

robertjchen commented 5 months ago

paused for now

robertjchen commented 4 months ago

no update

robertjchen commented 3 months ago

no update

robertjchen commented 2 months ago

no update

robertjchen commented 4 weeks ago

no update

robertjchen commented 12 hours ago

no update