Open kavimuru opened 1 year ago
I can invite internal Expensify team members, but might be best to ask @mrousavy or someone from your team for an invite @hannojg! (I think @chrispader was just added last month)
Hey, i just joined the React Contributors react discord - are you able to add me into the according channels?
Discord username is hannojg
I don't think I can add you, but #contributors-hub might be the best channel to discuss?
Already invited you hanno.
Update: My solution was judged as "makes sense" from two core contributors. It was forwarded to some other people for a final pass, so i am confident that the solution will be used moving forward. However, i just noticed that the fix doesn't seem to work in the use-case in expensify. Its very likely because the input in expensify is a controlled one. I am now investigating how to bring the fix to the controlled text input (the fix itself should be similar/the same)
Okay, i finally have a PR up in react-native:
Will update our PR shortly!
Okay, the PR is updated. However, i noticed that my patch doesn't work 100% when bridgeless mode is turned off. As we are working on turning that on (and looks like we are close), I'd like to take this on hold for:
Update: bridgeless support was merged, but was deactivated on android again. Lets put this on hold for this PR where we aim to reactivate bridgeless mode for android:
updated the hold
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
+
in the compose box > Request moneyExpected Result:
No jumpy behavior when entering the digits
Actual Result:
Request money component is jumpy
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.22 Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/c8c41359-c830-486a-8b17-ae78f89e0631
Expensify/Expensify Issue URL: Issue reported by: @mountiny Slack conversation: https://expensify.slack.com/archives/C9YU7BX5M/p1685628667713269
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hannojg