[$2000] HIGH: Implement Comment Linking

[mountiny]

This is a public issue to track implementation of the Comment Linking feature (internal link).

Margelo will work on the App implementation of this project

Design doc can be found here - also internal

Roll out plan

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0116b1ab0be62d4242
• Upwork Job ID: 1777848479203676160
• Last Price Increase: 2024-04-10

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[perunt]

I would like to do this

[puneetlath]

@chiragsalian I don't think you need me here so going to un-assign. But feel free to re-assign me if I missed something.

[perunt]

@chiragsalian could you apply the Review label to this doc?

[melvin-bot[bot]]

:wave: Hello Generalist Track Team - you have been assigned to review this High Level Design Doc. Please, treat this as a priority. Review this Stack Overflow for some tips on reviewing a design doc. Once you are done, simply press the Add "Reviewed Doc" comment button in the right hand side K2 pannel or follow these instructions.

---

• @jasperhuangg (Expensifier / Graduate) - https://github.com/Expensify/App/issues/21006
• @sarajojacobson (Expensifier / Graduate) - https://github.com/Expensify/App/issues/21007
• @zsgreenwald (Project Manager) - https://github.com/Expensify/App/issues/21008
• @StefStavri (Project Manager) - https://github.com/Expensify/App/issues/21009
• @laurenreidexpensify (Product Manager) - https://github.com/Expensify/App/issues/21010
• @robertjchen (Product Manager) - https://github.com/Expensify/App/issues/21011
• @cead22 (Generalist) - https://github.com/Expensify/App/issues/21012
• @anmurali (Generalist) - https://github.com/Expensify/App/issues/21013
• @HaleyJacobson (Accounting Technical Team) - https://github.com/Expensify/App/issues/21014

[mountiny]

Design doc link here.

[sarajojacobson]

I have read and reviewed this Design Doc.

[chiragsalian]

Coming from this slack post, please prioritize reviewing the design doc as a daily effort if you are not focusing on SNH since this feature is a critical feature for NewDot.

[flodnv]

I have read and reviewed this Design Doc!

[StefStavri]

I have read and reviewed this Design Doc!

[chiragsalian]

In progress, looks like we got most of the review comments. @robertjchen would you also be able to review the comment linking design doc soon (asking cause you are the only product manager reviewer pending before we can move to the technical section review)

[robertjchen]

I have read and reviewed this Design Doc!

[Beamanator]

I have read and reviewed this Design Doc!

[chiragsalian]

Alright looks like we got the required number of high-level reviews. Let's move ahead to the technical review. @perunt when you get a chance remember to go over all high-level comments and address them.

[melvin-bot[bot]]

:wave: Hello Generalist Track Team - you have been assigned to review this Detailed Design Doc. Please, treat this as a priority. Review this Stack Overflow for some tips on reviewing a design doc. Once you are done, simply press the Add "Reviewed Doc" comment button in the right hand side K2 pannel or follow these instructions.

---

• @jasperhuangg (Expensifier / Graduate) - https://github.com/Expensify/App/issues/22568
• @CortneyOfstad (Expensifier / Graduate) - https://github.com/Expensify/App/issues/22569
• @zsgreenwald (Project Manager) - https://github.com/Expensify/App/issues/22570
• @StefStavri (Project Manager) - https://github.com/Expensify/App/issues/22571
• @cead22 (Product Manager / Generalist + Engineer) - https://github.com/Expensify/App/issues/22572
• @robertjchen (Product Manager / Generalist + Engineer) - https://github.com/Expensify/App/issues/22573
• @joelbettner (Product Manager / Generalist + Engineer) - https://github.com/Expensify/App/issues/22574
• @johnmlee101 (Product Manager / Generalist + Engineer) - https://github.com/Expensify/App/issues/22575
• @anmurali (Product Manager / Generalist + Non-Engineer) - https://github.com/Expensify/App/issues/22576
• @laurenreidexpensify (Product Manager / Generalist + Non-Engineer) - https://github.com/Expensify/App/issues/22577
• @stephanieelliott (Product Manager / Generalist + Non-Engineer) - https://github.com/Expensify/App/issues/22578
• @RobertLadue (Product Manager / Generalist + Non-Engineer) - https://github.com/Expensify/App/issues/22579

[cead22]

I have read and reviewed this Design Doc!

[CortneyOfstad]

I have read and reviewed this Design Doc!

[johnmlee101]

I have read and reviewed this Design Doc!

[laurenreidexpensify]

I have read and reviewed this Design Doc!

[roryabraham]

I'm going help shepherd this initiative while @chiragsalian's away.

[roryabraham]

Still need 3 non-engineering product managers / generalists to review the detailed, and 2 project managers.

[joelbettner]

I have read and reviewed this Design Doc!

[robertjchen]

I have read and reviewed this Design Doc!

[stephanieelliott]

I have read and reviewed this Design Doc!

[StefStavri]

I have read and reviewed this Design Doc!

[roryabraham]

I just updated the rollout plan to include a bit more detail.

At this point, this doc has gone through many reviews and revisions, and we are only short 2 non-engineering generalists, so I'm doing a last call here. This project will go into the implementation phase tomorrow.

[anmurali]

I have read and reviewed this Design Doc!

[roryabraham]

Going to move this forward into the implementation phase and start creating issues now.

[roryabraham]

Created a project board to start tracking implementation: https://github.com/orgs/Expensify/projects/62/views/1, also created an internal issue to make that project board publicly visible

[roryabraham]

Alright, all the issues have been created. Feel free to follow the implementation in the GitHub Project

[JmillsExpensify]

I have read and reviewed this Design Doc!

[roryabraham]

Posted project update in slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1690393798476199

[HaleyJacobson]

I have read and reviewed this Design Doc!

[RobertLadue]

I have read and reviewed this Design Doc!

[roryabraham]

Weekly update:

• We have a PR in review for GetOlderActions and GetNewerActions
• previousReportActionID Onyx migration PR was just merged
• Front-end FlatList bugs are fixed (we still need to finish upgrading react-native-web, which just came off hold)
• I am still working on adding previousReportActionID to all reportActions in Auth. It's taken longer than it should have, but should be ready for review by EOD

[chiragsalian]

Not overdue, still in progress.

[flodnv]

I'm curious about the progress, could we please get an update like @roryabraham's last one above? 🙏

[roryabraham]

Hey, sorry my updates here have been lackluster on this issue, but I did drop an update in slack last week here

[roryabraham]

@aldo-expensify raised his hand on https://github.com/Expensify/App/issues/23218, thanks @aldo-expensify! I'm still working on https://github.com/Expensify/Web-Expensify/pull/38662

Also, I'm making this issue a daily since we're shooting to finish this by end-of-offshore

[roryabraham]

We had a number of PRs merged for this last week. Still working on the last backend piece then this should be prettymuch all front-end.

[roryabraham]

Actively implementing :working:

[roryabraham]

previousReportActionID isn't really working due to old reportActions being cached in PHP. Created https://github.com/Expensify/Auth/pull/8764 to fix it

[melvin-bot[bot]]

@chiragsalian, @roryabraham, @perunt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[roryabraham]

Quick EOW update:

• I still need to re-review https://github.com/Expensify/App/pull/26166, but haven't been urgently prioritizing because there's still an issue with the back-end logic for previousReportActionID, which will be needed for the next step which actually enables comment linking
• The back-end PR has been ready and approved for 3 days, but has been held up by failing tests in Web-Expensify – some which needed to be temporarily disabled and others which are unrelated and failing on main.

[roryabraham]

Has been delayed by my OOO but I just commented on the PR to hopefully help unblock it

[melvin-bot[bot]]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[cristipaval]

Did Melvin assign me by mistake or I'm missing something

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @roryabraham, @perunt eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!