DEV: Console warning at payments page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Go to settings > Payments
3. Click on a payment method
4. Check console

Expected Result:

There shouldn't be any console warning

Actual Result:

We get a console warning

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: DEV Reproducible in staging?: N/A Reproducible in production?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/7fe86741-df66-4bb3-98fd-3d200e228ba1

Expensify/Expensify Issue URL: Issue reported by: @daraksha-dk Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684868310292979

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal by @daraksha-dk

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console warning at payments page

What is the root cause of that problem?

It's happening when the value for shouldShowMakeDefaultButton is false, resulting false being passed to style prop which will cause warning.

What changes do you think we should make in order to solve the problem?

To fix this, we can either update style's propType definition to accept boolean values or we can just update this line like below:

                   style={shouldShowMakeDefaultButton ? [styles.mt4] : undefined}

What alternative solutions did you explore? (Optional)

We can update the definition to include boolean here and use stylePropTypes here

[dhairyasenjaliya]

@JmillsExpensify this issue is a dupe and already fixed here https://github.com/Expensify/App/pull/20117 and this can be closed

[JmillsExpensify]

Thank you! I wasn't able to reproduce any console errors on the latest, so I do think we're good here. Please re-open if I've missed something.