Closed francoisl closed 6 months ago
Triggered auto assignment to @abekkala (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
@jczekalski FYI. GH won't let me co-assign you for some reason, feel free to co-assign yourself to this issue.
@francoisl I can't assign myself. Perhaps you'll be able to co-assign me once I've commented in the issue?
EOW update: Jan has been partially OOO this week, and I didn't have much time to update the doc. Hoping to resume working on this next week! 💪
Would this video player also work for audio files (e.g. mp3)? I'm assuming yes, because I'm thinking of it as a "media player" rather than "video player" but let me know if that's incorrect!
@puneetlath this was brought up during the second pre-design (here), and Jan recommended we focus on video for now, since supporting audio files would possibly require different libs.
Getting back to this, opened a Design issue to get started on the mockups. Will work on the high-level design doc this week.
Hey @francoisl, I've already filled out some sections of the design doc, though it's still WIP and I'm working on a copy. Should I move everything to the actual design doc?
Good to hear, thanks! For now it's fine, you can keep it in your WIP copy. One question though - did you figure out if we'll need to make backend changes to generate and store thumbnails – or if we'll be able to make the thumbnails directly from the client?
Waiting on the mockups, in the meantime I remade a new design doc with the new template, and will continue filling it out.
Hey @francoisl, I recently started working on a different project at Software Mansion and this issue was transferred to a different developer. I'll ask him to comment in the issue, so you can assign him.
Hey @francoisl, recently I've taken this task from Jan and started working on it. For now, I was creating my own POC where I was testing available packages and investigating challenges connected to them. Also, I continued writing Jan's design doc copy. I think we are having most of the information about the video player so I moved everything to the main file so you can take a look :D
The doc is making good progress thanks to Michał. There's one open question regarding thumbnails that we took to Slack, other than that the doc is almost ready for review.
This issue has not been updated in over 15 days. @francoisl, @Skalakid eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
It's not overdue Melvin. I posted an update to this issue without realizing not everyone had access to it.
Here's where we settled for the video player UI. ⏯️
You can find these screens (and all the little pieces for the player UI) in the NewDot / Video Player Figma file.
For the "more" 3-dot menu, we want to use our standard context menu styling.
High-level design doc sent out for review, going to apply the DesignDocReview
label to get some reviewers assigned.
https://docs.google.com/document/d/1Fh5Nu3D0-VW7xuV9Qc-OWWZl3-W5azx7Rr1lzNw4UGo/edit
:wave: Hello Generalist Track Team - you have been assigned to review this High Level Design Doc. Please, treat this as a priority. Review this Stack Overflow for some tips on reviewing a design doc. Once you are done, simply press the Add "Reviewed Doc" comment
button in the right hand side K2 pannel or follow these instructions.
@MonteExpensify
(Expensifier / Graduate) - https://github.com/Expensify/App/issues/27061@tylerkaraszewski
(Expensifier / Graduate) - https://github.com/Expensify/App/issues/27062@zsgreenwald
(Project Manager) - https://github.com/Expensify/App/issues/27063@sakluger
(Project Manager) - https://github.com/Expensify/App/issues/27064@nkuoch
(Product Manager) - https://github.com/Expensify/App/issues/27065@laurenreidexpensify
(Product Manager) - https://github.com/Expensify/App/issues/27066@ryanschaffer
(Generalist) - https://github.com/Expensify/App/issues/27067@danielrvidal
(Generalist) - https://github.com/Expensify/App/issues/27068@heyjennahay
(Accounting Technical Team) - https://github.com/Expensify/App/issues/27069I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
Front-end part of the detailed section is mostly done, going to work on the backend.
Detailed section of the doc is ready for review, going to reapply the DesignDoc label to get reviewers assigned.
:wave: Hello Generalist Track Team - you have been assigned to review this Detailed Design Doc. Check out this Stack Overflow for some tips on reviewing a design doc. Once you are done, simply press the Add "Reviewed Doc" comment
button in the right hand side K2 panel or follow these instructions.
@zsgreenwald
(Any Expensifiers, Non-Engineering Graduates or Project Managers) - https://github.com/Expensify/App/issues/30937@MonteExpensify
(Any Expensifiers, Non-Engineering Graduates or Project Managers) - https://github.com/Expensify/App/issues/30938@danielrvidal
(Non-engineering Product Managers or Generalists) - https://github.com/Expensify/App/issues/30939@laurenreidexpensify
(Non-engineering Product Managers or Generalists) - https://github.com/Expensify/App/issues/30940@tylerkaraszewski
(Engineering Graduates) - https://github.com/Expensify/App/issues/30941@nkuoch
(Engineering Graduates) - https://github.com/Expensify/App/issues/30942@marcochavezf
(Engineering Graduates) - https://github.com/Expensify/App/issues/30943@joelbettner
(Engineering Product Managers or Generalists) - https://github.com/Expensify/App/issues/30944I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
I have read and reviewed this Design Doc!
The project board is up with the issues, update here in Slack: https://expensify.slack.com/archives/C05NTGSDSF2/p1702093797797469
Since the Video Player feature is a blocker for other tasks and most of the code was written before introduction of TS restrictions, we decided to add new JS files to the main. As soon as we will merge https://github.com/Expensify/App/pull/30829, we need to migrate following files to TS:
This issue has not been updated in over 15 days. @francoisl, @Skalakid eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
The video player is on staging now!
Centralizing issues and follow-up tasks in this issue.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Proposal
Original Proposal WN Internal Proposal Project
Proposal: Add a Video Player to NewDot
Problem At the moment, when a video is sent as a message, it is treated as a generic file attachment. This means that one has to first download it to their device, and then open it separately, out of the app. Not only does this provide a subpar user experience, it's also inconsistent with images, which are displayed directly in the chat.
Solution Add the ability for NewDot to play videos in-app, by implementing a video player.
Design Doc
https://docs.google.com/document/d/1Fh5Nu3D0-VW7xuV9Qc-OWWZl3-W5azx7Rr1lzNw4UGo/edit
Pre-designs
Pre-design 1 Pre-design 2
Tasks
#expensify-open-source
strategy@expensify.com
and paste in the Proposalstrategy@expensify.com
(continue the same email chain as before) with the link to your Design Doc#expensify-open-source
to discuss any necessary details in public before filling out the High-level of proposed solution section.stategy@expensify.com
again with links to the doc and pre-design conversation in SlackDesignDocReview
label to get the High-level of proposed solution section reviewed#expensify-open-source
to ask for engineering feedback on the technical solution.DesignDocReview
label to this issuestrategy@expensify.com
one last time to let them know the Design Doc is moving into the implementation phasestrategy@expensify.com
once everything has been implemented and do a Project Wrap-Up retrospective that provides: