Closed kavimuru closed 1 year ago
Triggered auto assignment to @muttmuure (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are ✅):wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash
deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Triggered auto assignment to @luacmartins (Engineering
), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
The "Hmm... it's not here" page is displayed when attempting to view a profile after splitting the bill
We are using login
in MoneyRequestConfirmationList
.
https://github.com/Expensify/App/blob/83ab0160a3b5c385fd26fffe20bdbccabf9249c0/src/components/MoneyRequestConfirmationList.js#L236-L241
We shall update the login
to accountID
as per new implementations.
The "Hmm... it's not here" page is displayed when attempting to view a profile after splitting the bill.
Empty string gets passed for ReportUtils.getAccountIDForLogin(option.login)
here as that function call won't work bcoz we are passing loginId here and inside function getAccountIDForLogin
it is fetching from personalDetailsList
onyx key which has the mapping with accountID's.
We have the accountID
here for the option object which we can use directly.
Navigation.navigate(ROUTES.getProfileRoute(option.accountID));
Also this condition can be updated with accountID. https://github.com/Expensify/App/blob/bee8fd3e1634fa11761435ef405a3d3efd654b07/src/components/MoneyRequestConfirmationList.js#L237
!option.accountID
Looks like something related to react-navigation
may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js
files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.
@0xmiroslav sorry it looks like you linked the PR twice, did you mean to link an issue?
@0xmiroslav sorry it looks like you linked the PR twice, did you mean to link an issue?
well first one is my comment which reported this issue 2nd one is PR which fixes this issue comment is inside that PR 😀
Aahhh this is the "Also, there was another new issue happening on main" issue, yeah? Great, i'll make this not a deploy blocker 😬
@luacmartins whenever you see this, feel free to close if it's not reproducible (since it shouldn't be 🙏 )
I can't reproduce this, but I also see no emails/display names in the list
@luacmartins do you have clear reproducible step? I am not able to reproduce.
@0xmiroslav same as the OP.
I am not able to reproduce but instead __fake__
user appears. @Beamanator Is this being fixed somewhere?
https://github.com/Expensify/App/assets/97473779/6f892af2-04e0-4a2d-acc6-899b91d2b83e
@luacmartins I think your issue has the same root cause as #21127
FYI...
I also see no emails/display names in the list
This was fixed earlier in PR: https://github.com/Expensify/App/pull/21113
This specific issue has been fixed. We had other issues for the missing display names, etc. Closing.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Clicking on a profile after splitting the bill should display the profile details or images.
Actual Result:
Clicking on a profile after splitting the bill displays the "Hmm... it's not here" page instead of the profile details.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.29-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
screen-capture (15).webm
https://github.com/Expensify/App/assets/43996225/0a01ce7e-0a84-4b5f-99f8-998618b50490
Expensify/Expensify Issue URL: Issue reported by: @ayazhussain79 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686899440198109
View all open jobs on GitHub