Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Inconsistency in email font size when hovering over email and photo in group members section #20982

Closed kavimuru closed 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app and split a bill by selecting "Split Bill"
  2. Enter amount
  3. Select two random emails
  4. Select split
  5. Click on the report
  6. Hover over the email and then over the photo. When hovering over the email, the font size is displayed boldly, while when hovering over the photo, the font size is displayed lightly.

Expected Result:

When hovering over the email and photo, the email should have a consistent font size.

Actual Result:

When hovering over the email and photo, the tooltip shows different email font sizes.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.29-6 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL: Issue reported by: @tewodrosGirmaA Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687020595022329

View all open jobs on GitHub

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

kevinksullivan commented 1 year ago

I am unable to reproduce this on v1.3.28-3

image image

Taking to slack to get clarity on whether this is still an issue.

tewodrosGirmaA commented 1 year ago

Hi @kevinksullivan , this issue happened on staging v1.3.29-2

melvin-bot[bot] commented 1 year ago

📣 @tewodrosGirmaA! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
srikarparsi commented 1 year ago

Hi @kavimuru, I am also unable to reproduce this issue on staging or dev. Will close it out but please reopen if necessary

https://github.com/Expensify/App/assets/48188732/84b03f7a-938c-45f2-a359-cab6c237b0b1

https://github.com/Expensify/App/assets/48188732/943264cc-7483-4cb2-aca4-f039dfb3ceb6

kavimuru commented 1 year ago

@srikarparsi I am also not able to reproduce in the latest version.

tewodrosGirmaA commented 1 year ago

screen-capture (25).webm Hey @srikarparsi, can you check this situation? Go to the plus sign > split bill > add desired number and click "next" > click on the profile to see the details > hover over the split bill members' email and photo to observe the difference. The email text is bold, while the photo text is lighter ....since the root couse is semilar , in above I reproduced in group memebers , now this happen on split bill memebers. Thank you

tewodrosGirmaA commented 1 year ago

hey @kevinksullivan @srikarparsi , I was able to reproduce the issue with group members in version V1.3.29-0, but it's not happening there anymore. However, the same issue is now happening with split bill members in V1.3.29-2. More details are provided in the video above. Thank you

kevinksullivan commented 1 year ago

Discussed further in slack and it is a different issue specific to split bill, as @tewodrosGirmaA mentioned. Here's how they differ:

Staging

screen-capture (25).webm

Production

image
srikarparsi commented 1 year ago

Will close it out as the split bill members page is consistent with the group members page (both the avatar and the name are bold on hover and can be clicked on to visit profile). @kevinksullivan please reopen though if you feel we should look into it.