Split bill - Receiver can't see "Split bill $" at the LHN in case of long Sender's name/email

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR https://github.com/Expensify/App/pull/20752

Action Performed:

1. Create a Split bill (with a long Sender's email/name)
2. Check the Receiver's side LHN

Expected Result:

Receiver side should see "Split bill $summ" text at the LHN

Actual Result:

In case of long Sender's email/name there is not enough room at the LHN to see "Split bill $summ" on the Receiver's side

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/2077fd90-a97e-4078-a570-a6f3f29cf878

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[spcheema]

Proposed solution

Please re-state the problem that we are trying to solve in this issue.

Split bill amount is being trimmed due to long name of the last actor on split bill.

What is the root cause of that problem?

Max visible char fit in the LHN description is around 50 (lastActorDetails.displayName and lastMessageTextFromReport)

What changes do you think we should make in order to solve the problem?

In case of split bill report type: Render lastActorDetails.displayName & lastMessageTextFromReport into reparate containers and show ellipsis for lastActorDetails.displayName container only.

Below is final HTML output

<div aria-label="parent container "style="display: flex;">
  <div style="overflow: hidden;text-overflow: ellipsis;">Sp. long name Cheema fasdfasfsdfasdfsd</div>
  <div>: split A$35,555.00</div>
</div>

What alternative solutions did you explore? (Optional)

• Limit no. char visible for last actor display name.

So here is the formula:

if len(lastActorDetails.displayName) + len(lastMessageTextFromReport) > 50 {

    possibleNameLength = 50  - len(lastMessageTextFromReport)

    possibleNameLengthWithEllipsis =  possibleNameLength- 3

    then diplay `possibleNameLengthWithElipiss char of lastActorDetails.displayName` and `...`    
}

<img width="373" alt="Pasted Graphic" src="https://github.com/Expensify/App/assets/19812199/c9677d6b-7c14-4b76-96c9-ac376650c05a">

Another solution is leave it as-is since long name isn't very common. Only in South India

[MitchExpensify]

Unable to reproduce on Chrome:

[MitchExpensify]

Or on the desktop app:

Closing until we have reliable reproduction steps!

[spcheema]

@MitchExpensify it’s reproducible. Whenever last actor got a long name, split bill isn’t visible. But long names aren’t very as I mentioned in proposal

[MitchExpensify]

I am unable to reproduce using the step in the main issue. What steps are you following @spcheema ? Perhaps I can try them with more success

[spcheema]

@MitchExpensify Set long name for your profile as in the screenshot

then create a split bill and you will noticed the issue.

But I agree long names are not very common except South India