search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[HOLD for payment 2023-07-17] [$1000] Web - App throws 'No content to add' error if we send empty alias for email #21234

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open the app
  2. Open any report
  3. Type in a link with empty alias eg: [](google.com)
  4. Observe that app handles it well
  5. Send email with empty alias eg: [](test@test.com)
  6. Observe that app throws 'No content to add' for step 5 message

Expected Result:

App should handle empty alias for email in similar way like it does for link

Actual Result:

App throws 'No content to add' error for email with empty alias

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.30.0

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/3efe4b24-22e0-47e5-9758-5bae899a4dac

https://github.com/Expensify/App/assets/93399543/b68bed52-6612-4012-9223-1ffaf656b18d

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686755882619169

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012e72288a82e6fae6
  • Upwork Job ID: 1671920286239043584
  • Last Price Increase: 2023-06-29
laurenreidexpensify commented 1 year ago

@YacineF0001 unfortunately if you do not have an active Upwork account we will not be able to move forward here. Would recommend as a next step that you work with Upwork to have the account restored. We have plenty of issues available to work on with the help wanted label, so this won't be the only opportunity to pick up a job on our repos!

parasharrajat commented 1 year ago

Thanks @laurenreidexpensify . Please assign @eh2077 . Sorry for all the back and forth.

parasharrajat commented 1 year ago

@eh2077 Yeah.

eh2077 commented 1 year ago

@parasharrajat The PR https://github.com/Expensify/expensify-common/pull/555 for expensify-common is ready. Please help to review it at your convenience, thanks!

YacineF0001 commented 1 year ago

@laurenreidexpensify noted, i will try to restore it.

@eh2077 could you share bounty for me ?

eh2077 commented 1 year ago

@YacineF0001 I'm still open about it and I'll defer to the team to make that decision then as the guidelines suggest.

parasharrajat commented 1 year ago

We have already shared our opinion above. If you want to share the payment with anyone, it's your choice but that won't be done from our side as we only offer payments via Upwork, and in the absence of an Upwork account, we don't have any way of paying up.

YacineF0001 commented 1 year ago

yes, right. i can't get paid with upwork account. so @eh2077 can get full paid with it and share me in other way

parasharrajat commented 1 year ago

First PR merged. Onto next one.

eh2077 commented 1 year ago

@parasharrajat The PR https://github.com/Expensify/App/pull/22182 for App to bump version of expensify-common is ready.

melvin-bot[bot] commented 1 year ago

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

On to the next one 🚀

parasharrajat commented 1 year ago

Technically, this PR was merged in 3 days. There was some back and forth in the Contributor assignment which the bot didn't know. The real assignment to the right contributor happened https://github.com/Expensify/App/issues/21234#issuecomment-1619738189 2 days back.

cc: @laurenreidexpensify

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.38-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-17. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

laurenreidexpensify commented 1 year ago

@dhanashree-sawant @eh2077 offers have been sent in Upwork

@parasharrajat can you please work with @anmurali and @JmillsExpensify on payment for this on the C+ payment pilot, thanks

eh2077 commented 1 year ago

@laurenreidexpensify Accepted the offer thanks.

parasharrajat commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Regression Test Steps

  1. Go to a chat and add the following comment

    [](concierge@expensify.com)
[   ](concierge@expensify.com)
[   

](concierge@expensify.com)
  2. Verify that a. Only emails inside () are parsed as email links b. [], () and spaces(including line break) inside [] are not parsed
  3. Click to edit the comment
  4. Verify that the initial draft is the same as the original input.

Do you agree 👍 or 👎 ?

laurenreidexpensify commented 1 year ago

Payments issues + regression test requested.

@parasharrajat am closing, please proceed with payment request in newdot via @anmurali Thanks

parasharrajat commented 1 year ago

Payment requested 1500 based on https://github.com/Expensify/App/issues/21234#issuecomment-1623234741.

JmillsExpensify commented 1 year ago

@laurenreidexpensify Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @parasharrajat's NewDot payments. More information on this compliance process in Slack.

laurenreidexpensify commented 1 year ago

Payments:

JmillsExpensify commented 1 year ago

Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.