[HOLD for payment 2023-08-01] [$1000] Request Money - User gets highlighted in send/request money on changing of language during the process

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

From device 1, login with user A
From device 2, login with user A
From device 1, open any report, click on plus, click on send/request money, enter any amount and click continue
From device 2, change the language from English to Spanish or vis a versa
Observe in device 1 that user gets highlighted after language change (by default user is not highlighted)

Expected Result:

App should not highlight user in send/request money on language change

Actual Result:

App highlights user in send/request money while changing language during the process

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.29-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/c0e4ee98-fe71-45f4-a6d1-7859987300d2

https://github.com/Expensify/App/assets/93399543/427846e1-96a8-4add-b463-65338b625553

Expensify/Expensify Issue URL: Issue reported by:@dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687200047072349

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013b389dab3622e04c
Upwork Job ID: 1673230286457331712
Last Price Increase: 2023-07-17

melvin-bot[bot] commented 1 year ago

🎯 ⚡️ Woah @aimane-chnaif / @ShogunFire, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

when @ShogunFire got assigned: 2023-07-18 17:49:50 Z
when the PR got merged: 2023-07-21 16:00:58 UTC

On to the next one 🚀

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.44-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/23117

If no regressions arise, payment will be issued on 2023-08-01. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[x] External issue reporter
[x] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@ShogunFire requires payment
@aimane-chnaif requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[x] [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x] [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[x] [@aimane-chnaif] Determine if we should create a regression test for this bug.
[x] [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[x] [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: