[HOLD for payment 2023-07-17] [$1000] Web - Mouse cursor is shown as hand icon (on a not clickable section) on who paid, split bill

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to '+" -> new group -> select members
2. Click create group
3. Now it should show a new group page
4. Go to ''+" on new group page -> split bill -> type the amount -> next
5. Notice who paid? card section, the cursor is shown as the mouse pointer

Expected Result:

The arrow cursor should be shown instead of mouse cursor as the who paid section ( where the user who paid is shown)

Actual Result:

Mouse cursor is shown as hand icon (on a not clickable section) on who paid, split bill

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.30-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/f7b61150-3c9e-404e-a6ae-8cde0a2d9f59

https://github.com/Expensify/App/assets/93399543/181ad4d6-6f06-4ee2-899d-4b90304bca1b

Expensify/Expensify Issue URL: Issue reported by: @ashimsharma10 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687527115940319

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013377045cdf090308
• Upwork Job ID: 1673779406484242432
• Last Price Increase: 2023-06-27

[melvin-bot[bot]]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Mouse cursor is shown as hand icon (on a not clickable section) on who paid, split

What is the root cause of that problem?

What we expected:

Split Bill From Group

https://github.com/Expensify/App/assets/13113013/b8aaacc6-9cca-4977-be0f-231db65c0db3

Split Bill From FAB

https://github.com/Expensify/App/assets/13113013/f0eeb825-b0fa-445e-8f23-e1ce2d0f4d37

What changes do you think we should make in order to solve the problem?

We add isReadOnly prop to OptionRow component. This prop is used for 'Who paid' section when can modify participants.

• Not have hover and press effect.
• Default cursor on section.
• Pointer cursor on avatar, display name.
• Not-allowed cursor on SelectCircle.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~013377045cdf090308

[melvin-bot[bot]]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[Santhosh-Sellavel]

@ginsuma Your proposal didn't work for me, please check again!

[ginsuma]

@Santhosh-Sellavel My proposal shows like that. Can you describe how should it show?

[Santhosh-Sellavel]

Sorry for the confusion, my apologies it works. Something wrong with my setup. Working now.

[Santhosh-Sellavel]

@ginsuma's Proposal looks good here.

For CME This issue raises minor concerns,

On the confirmation page, while we create a SplitBill from a group chat, we will be able to unselect users from Who was there? but in the flow where we create a SpiltBill from the FAB button, we will not be able to unselect anyone still we allow to click on all the users and will show the User Details page. I believe post this proposal we will not be able to click Who paid in FAB flow also, are we fine with that, or should exclude that?

Recording Before on staging & now on dev

https://github.com/Expensify/App/assets/85645967/c9984146-8aec-46c8-98bd-0c00c5c799d7

C+ Reviewed 🎀 👀 🎀

cc: @lschurr

[melvin-bot[bot]]

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[ginsuma]

@Santhosh-Sellavel For your concern, we can edit it to for working both cases:

const canModifyParticipants = !props.isReadOnly && props.canModifyParticipants && props.hasMultipleParticipants;
 {
    title: translate('moneyRequestConfirmationList.whoPaid'),
    data: [formattedPayeeOption],
    shouldShow: true,
    indexOffset: 0,
    isDisabled: canModifyParticipants,
},

[ginsuma]

Proposal

Updated

[Santhosh-Sellavel]

Cool @ginsuma, I'm not sure whether we want that, thanks anyway! Let's wait for @amyevans!

[amyevans]

I'm not sure that disabling the Who Paid section is the way we should go from a design perspective (for instance, I could see an alternative being removing the circle/checkmark altogether). So I'd like @Expensify/design's eyes on it first before we proceed.

[Santhosh-Sellavel]

Good call @amyevans!

[shawnborton]

I like keeping the checkmark to indicate that the person is included, but I think I would just make it so you can't interact with it.

[ginsuma]

Can you check the below is what we expected:

Split Bill From Group

https://github.com/Expensify/App/assets/13113013/b8aaacc6-9cca-4977-be0f-231db65c0db3

Split Bill From FAB

https://github.com/Expensify/App/assets/13113013/f0eeb825-b0fa-445e-8f23-e1ce2d0f4d37

[Santhosh-Sellavel]

@shawnborton Can you confirm this works for you?

[shawnborton]

Works for me!

[amyevans]

Cool, assigning @ginsuma!

[melvin-bot[bot]]

📣 @Santhosh-Sellavel You have been assigned to this job! Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @ginsuma You have been assigned to this job! Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @ashimsharma10 You have been assigned to this job! Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[ashimsharma10]

Bot is not assigning properly. Please someone check.

[ginsuma]

https://github.com/Expensify/App/pull/21945 PR is up @amyevans @Santhosh-Sellavel .

[amyevans]

Heads up I'm OOO Mon/Tue next week.

[melvin-bot[bot]]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @ginsuma got assigned: 2023-06-29 17:15:04 Z
• when the PR got merged: 2023-07-06 14:28:19 UTC
• days elapsed: 4

On to the next one 🚀

[melvin-bot[bot]]

@amyevans, @ginsuma, @lschurr, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

[Santhosh-Sellavel]

PR is Merged!

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.38-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/21945

If no regressions arise, payment will be issued on 2023-07-17. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [ ] [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@ashimsharma10 @Santhosh-Sellavel @ginsuma - please apply for the job in Upwork here: https://www.upwork.com/jobs/~013377045cdf090308

[Santhosh-Sellavel]

@lschurr Will collect on ND.

[ashimsharma10]

@lschurr applied!

[ginsuma]

I applied. Thanks.

[lschurr]

@Santhosh-Sellavel could you work on the checklist? Do we need a regression test?

[Santhosh-Sellavel]

I think we can skip the checklist here as it's not a regression but rather a minor UX polish. cc: @amyevans thoughts?

[amyevans]

Agreed!

[lschurr]

Thanks all! I'll issue payments on Monday and close.

[lschurr]

@ashimsharma10 - could you clarify what's going on in Upwork? Did you accept the offer?

[ashimsharma10]

@lschurr it is shown "withdrawn offer". Can u please offer me again at https://www.upwork.com/freelancers/~018a92cf13e1e88eed.

[lschurr]

Payments are sent. Closing.

[Santhosh-Sellavel]

Requested for payment on ND. ($1000)

[anmurali]

Approved based on https://github.com/Expensify/App/issues/21695#issuecomment-1636173729