Closed kbecciv closed 1 year ago
Triggered auto assignment to @lschurr (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are β
)Web - Mouse cursor is shown as hand icon (on a not clickable section) on who paid, split
What we expected:
We add isReadOnly
prop to OptionRow
component.
This prop is used for 'Who paid' section when can modify participants.
Job added to Upwork: https://www.upwork.com/jobs/~013377045cdf090308
Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External
)
@ginsuma Your proposal didn't work for me, please check again!
@Santhosh-Sellavel My proposal shows like that. Can you describe how should it show?
Sorry for the confusion, my apologies it works. Something wrong with my setup. Working now.
@ginsuma's Proposal looks good here.
For CME This issue raises minor concerns,
On the confirmation page, while we create a SplitBill from a group chat, we will be able to unselect users from Who was there?
but in the flow where we create a SpiltBill from the FAB button, we will not be able to unselect anyone still we allow to click on all the users and will show the User Details page. I believe post this proposal we will not be able to click Who paid in FAB flow also, are we fine with that, or should exclude that?
https://github.com/Expensify/App/assets/85645967/c9984146-8aec-46c8-98bd-0c00c5c799d7
C+ Reviewed π π π
cc: @lschurr
Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@Santhosh-Sellavel For your concern, we can edit it to for working both cases:
const canModifyParticipants = !props.isReadOnly && props.canModifyParticipants && props.hasMultipleParticipants;
{
title: translate('moneyRequestConfirmationList.whoPaid'),
data: [formattedPayeeOption],
shouldShow: true,
indexOffset: 0,
isDisabled: canModifyParticipants,
},
Cool @ginsuma, I'm not sure whether we want that, thanks anyway! Let's wait for @amyevans!
I'm not sure that disabling the Who Paid
section is the way we should go from a design perspective (for instance, I could see an alternative being removing the circle/checkmark altogether). So I'd like @Expensify/design's eyes on it first before we proceed.
Good call @amyevans!
I like keeping the checkmark to indicate that the person is included, but I think I would just make it so you can't interact with it.
Can you check the below is what we expected:
@shawnborton Can you confirm this works for you?
Works for me!
Cool, assigning @ginsuma!
π£ @Santhosh-Sellavel You have been assigned to this job! Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing π
π£ @ginsuma You have been assigned to this job! Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing π
π£ @ashimsharma10 You have been assigned to this job! Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing π
Bot is not assigning properly. Please someone check.
https://github.com/Expensify/App/pull/21945 PR is up @amyevans @Santhosh-Sellavel .
Heads up I'm OOO Mon/Tue next week.
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one π
@amyevans, @ginsuma, @lschurr, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?
PR is Merged!
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.38-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-17. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
@ashimsharma10 @Santhosh-Sellavel @ginsuma - please apply for the job in Upwork here: https://www.upwork.com/jobs/~013377045cdf090308
@lschurr Will collect on ND.
@lschurr applied!
I applied. Thanks.
@Santhosh-Sellavel could you work on the checklist? Do we need a regression test?
I think we can skip the checklist here as it's not a regression but rather a minor UX polish. cc: @amyevans thoughts?
Agreed!
Thanks all! I'll issue payments on Monday and close.
@ashimsharma10 - could you clarify what's going on in Upwork? Did you accept the offer?
@lschurr it is shown "withdrawn offer". Can u please offer me again at https://www.upwork.com/freelancers/~018a92cf13e1e88eed.
Payments are sent. Closing.
Requested for payment on ND. ($1000)
Approved based on https://github.com/Expensify/App/issues/21695#issuecomment-1636173729
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The arrow cursor should be shown instead of mouse cursor as the who paid section ( where the user who paid is shown)
Actual Result:
Mouse cursor is shown as hand icon (on a not clickable section) on who paid, split bill
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.30-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/f7b61150-3c9e-404e-a6ae-8cde0a2d9f59
https://github.com/Expensify/App/assets/93399543/181ad4d6-6f06-4ee2-899d-4b90304bca1b
Expensify/Expensify Issue URL: Issue reported by: @ashimsharma10 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687527115940319
View all open jobs on GitHub
Upwork Automation - Do Not Edit