[HOLD for payment 2023-08-02] [$1000] App does not focus on compose box on mark as read/unread when we visit other profile and get back

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any group report
3. Right click on group report in LHN and click on mark as read/unread to observe that it focuses on compose box
4. Now open group details page by clicking on group avatar, click on any user and click on message
5. Use browser back button to get back to group chat, right click on group chat in LHN and click on mark as unread
6. Observe the it does not focus on compose box

   Expected Result:

   App should focus on compose box on click of mark as unread/read for any chat from LHN

   Actual Result:

   App does not focus on compose box on click of mark as unread/read for group chat from LHN if we open group details, click on any user, click message and click on browser back to come back to group chat

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.33-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/04a8c119-789d-453f-adf9-0da4a6593b03

https://github.com/Expensify/App/assets/43996225/5899072b-fcb4-40df-928c-fb3fc7566561

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687606178130269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012eff16d4d91d5c21
• Upwork Job ID: 1673981095886499840
• Last Price Increase: 2023-07-12

[melvin-bot[bot]]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[conorpendergrast]

Reproduced on OSX desktop app too

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~012eff16d4d91d5c21

[melvin-bot[bot]]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After going back from another chat, the composer won't focus after pressing Mark as read/unread. To be clearer, the composer focus manager doesn't work.

What is the root cause of that problem?

We have a composer focus manager that will listen to any call of ReportActionComposeFocusManager.focus(). https://github.com/Expensify/App/blob/94e265653f83505e581e99ac0ec0d3ea30e23998/src/pages/home/report/ReportActionCompose.js#L229-L237

When we open chat A, a listener is added. https://github.com/Expensify/App/blob/94e265653f83505e581e99ac0ec0d3ea30e23998/src/libs/ReportActionComposeFocusManager.js#L7-L15

Navigating to chat B will replace the A listener with B. When we press back from B, B will unmount and the listener is cleared. https://github.com/Expensify/App/blob/94e265653f83505e581e99ac0ec0d3ea30e23998/src/pages/home/report/ReportActionCompose.js#L275-L277

What changes do you think we should make in order to solve the problem?

Initialize the listener on both mount and update. On update, only add the listener if the screen becomes focused, i.e.

if (!prevProps.isFocused && this.props.isFocused) { focusManager.onComposerFocus() }

What alternative solutions did you explore? (Optional)

Currently, we only store the latest callback. Instead,

1. We can change it to an array and push a new callback every time a new listener is added.
2. Return a function to unsubscribe it instead of using clear.
3. When calling focus, iterate over the array and invoke the callback

snippet

``` function onComposerFocus(callback) { const prevCallbacks = [...focusCallback]; focusCallback.push(callback); return () => { focusCallback = prevCallbacks; } } function focus() { _.each(focusCallback, (callback) => { if (!_.isFunction(callback)) { return; } callback(); }); } ```

[melvin-bot[bot]]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[aimane-chnaif]

Proposals are in review

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[conorpendergrast]

@aimane-chnaif Do any of these proposals look promising?

[aimane-chnaif]

Still evaluating

[conorpendergrast]

@aimane-chnaif Still nothing?

[melvin-bot[bot]]

@conorpendergrast @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aimane-chnaif]

@bernhardoj I agree with your RCA. Can you make sure that your solution doesn't break current autofocus behavior on mobile? Especially when report screens are stacked and click back button?

[bernhardoj]

I currently have issues running the app. Will confirm once it's resolved!

[bernhardoj]

current autofocus behavior on mobile

this still works fine

report screens are stacked and click back button

So, the ReportActionComposeFocusManager.onComposerFocus is actually for the web and is only triggered from context menu actions, so this one doesn't change anything related to the autofocus. Also, autofocus after going back from a report is also implemented only for the web, but I still tested it and it works fine.

https://github.com/Expensify/App/blob/9ef57bc4b35a7230c2aa00783b613519cd9b3413/src/pages/home/report/ReportActionCompose.js#L270-L275

willBlurTextInputOnTapOutside is false for the native.

[aimane-chnaif]

@bernhardoj what about mWeb?

[bernhardoj]

Tested on mWeb too

[conorpendergrast]

@aimane-chnaif Looks like we're good to go here, is that correct?

[aimane-chnaif]

@aimane-chnaif Looks like we're good to go here, is that correct?

yes, @bernhardoj's proposal looks good. 🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

@conorpendergrast @grgia @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot[bot]]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot[bot]]

📣 @bernhardoj You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[bernhardoj]

PR is ready

cc: @aimane-chnaif

[melvin-bot[bot]]

🎯 ⚡️ Woah @aimane-chnaif / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-07-19 16:15:18 Z
• when the PR got merged: 2023-07-24 15:11:56 UTC

On to the next one 🚀

[conorpendergrast]

@bernhardoj A reminder to apply to the Upwork job please!

[bernhardoj]

@conorpendergrast Applied

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.45-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/23181

If no regressions arise, payment will be issued on 2023-08-02. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [x] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment
• @aimane-chnaif requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [ ] [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[conorpendergrast]

Payouts due:

• [x] Issue Reporter: $250 @dhanashree-sawant
• [x] Contributor: $1000 + 50% urgency bonus = $1500 @bernhardoj
• [x] Contributor+: $1000 + 50% urgency bonus = $1500 @aimane-chnaif

Eligible for 50% #urgency bonus? Y

Upwork job is here

[conorpendergrast]

Everyone paid. @aimane-chnaif C+ checklist, please, and then I'll do a regression test (if necessary) and we can close this out

[aimane-chnaif]

I don't think regression test is needed as this isn't critical issue and doesn't prevent user using the app. Even it's not easy to follow repro step.

[conorpendergrast]

Alright, then we're all done. Thank you!