Closed kbecciv closed 1 year ago
Triggered auto assignment to @Christinadobrzyn (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are ✅)I can't reproduce this on MacOS / Chrome / Safari, asking if it's still happening - https://expensify.slack.com/archives/C049HHMV9SM/p1687905235179519?thread_ts=1687688275.769119&cid=C049HHMV9SM
This is reproducible on Windows.
Hey @tienifr do we test on windows?
I can't reproduce on Android, Chrome/Safari, iOS, Mac. I think that's all we test on, right?
Yeah, I think the root cause is about the font family. The fall-back font on Windows is Segoe UI Emoji. This font may not have the black couplekiss
emoji. That's my guess. Wait internal confirmation whether this is a bug.
Job added to Upwork: https://www.upwork.com/jobs/~013e72f32679d51f10
Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal
)
I don't think we test on Windows products at this time so I don't think this needs to be fixed but I'll add a C+ to confirm.
Making this Internal
until we determine if this should be fixed. If yes, i can make it external
.
@eVoloshchak just nudging this, should we fix this windows emoji issue? only affecting windows?
@Christinadobrzyn, I personally think we should fix Windows, since I suspect most people access NewDot from Windows (no data to back this up, but Windows is the most popular OS). In addition to that, I remember a couple of issues in the past that were fixing Windows-specific issues. That was a while back, not sure if our policy (if there is any) has changed
Asking what version of windows was used to test this so I can do some testing - https://expensify.slack.com/archives/C049HHMV9SM/p1687974216623249?thread_ts=1687688275.769119&cid=C049HHMV9SM
I don't have any method to test this on a Windows 10 Pro - asking the team if anyone can test.
https://expensify.slack.com/archives/C01SKUP7QR0/p1688409525853629
@eVoloshchak are you able to reproduce on a Windows 10 Pro?
It sounds like Windows PC is out of scope since we can't test on it - based on this Slack chat - https://expensify.slack.com/archives/C01SKUP7QR0/p1688409525853629
So closing this for now. feel free to reopen if we start working on Windows PC issues!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The emojis should not overlap when changing the default skin tone for the "coupleKiss" emoji.
Actual Result:
Some emojis overlap when changing the default skin tone for the "coupleKiss" emoji, causing visual issues.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop
[X] Edition Windows 10 Pro Version 22H2 Installed on 8/16/2021 OS build 19045.3086 Experience Windows Feature Experience Pack 1000.19041.1000.0
Version Number: v1.3.33-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/ddb26d92-42b2-46d4-9005-f186f7a54297
https://github.com/Expensify/App/assets/93399543/d099a7bf-6525-45ab-aec1-b8208c6c9737
Expensify/Expensify Issue URL: Issue reported by: @tewodrosGirmaA Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687688275769119
View all open jobs on GitHub
Upwork Automation - Do Not Edit