[HOLD for payment 2023-07-21] [$1000] Spanish character to room name shows the invalid name

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App, Press FAB > New room
2. Add Spanish character to the Room name (e.g. cueva-de-opinión)

Expected Result:

We should not get the error of invalid Room name and the Spanish character should be a valid name

Actual Result:

Adding a Spanish character shows the error of an invalid room name

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.33-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/8c71790f-4fef-488f-9e78-86e7199cef24

https://github.com/Expensify/App/assets/43996225/46037323-60f2-4df2-aa3a-1e5eac96cae5

Expensify/Expensify Issue URL: Issue reported by: @jayeshmangwani Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687765941593149

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01082e3b04cd3dad37
• Upwork Job ID: 1674121959020658688
• Last Price Increase: 2023-06-28

[melvin-bot[bot]]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

from @jayeshmangwani

Please re-state the problem that we are trying to solve in this issue.

Spanish character to room name shows the invalid name.

What is the root cause of that problem?

Here on the RoomNamePage page, we check the validity of the room name from the isValidRoomName function and

https://github.com/Expensify/App/blob/ae8a751c04cd4b371bec1d976da204413b6bb4b9/src/pages/settings/Report/RoomNamePage.js#L52-L54

https://github.com/Expensify/App/blob/ae8a751c04cd4b371bec1d976da204413b6bb4b9/src/libs/ValidationUtils.js#L424-L426

isValidRoomName check the valid room name with this regex;

https://github.com/Expensify/App/blob/ae8a751c04cd4b371bec1d976da204413b6bb4b9/src/CONST.js#L1135

above regex check the English character from a to z, but it does not allow Spanish character like é

What changes do you think we should make in order to solve the problem?

We have to update the regex here like that it can accept all the valid Spanish characters; we need to add the new range for taking the Spanish characters à-ÿ to ROOM_NAME regex.

https://github.com/Expensify/App/blob/ae8a751c04cd4b371bec1d976da204413b6bb4b9/src/CONST.js#L1135

    ROOM_NAME: /^#[a-z0-9-]{1,80}$/,
    ROOM_NAME: /^#[a-z0-9à-ÿ-]{1,80}$/,

What alternative solutions did you explore? (Optional)

Rather than adding the whole range of the alphabet, we can add only missing Spanish characters to the regex.

https://github.com/Expensify/App/blob/ae8a751c04cd4b371bec1d976da204413b6bb4b9/src/CONST.js#L1135

    ROOM_NAME: /^#[a-z0-9-]{1,80}$/,
    ROOM_NAME: /^#[a-z0-9-ñáéíóúü]{1,80}$/,

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accented Spanish characters are not permitted in room names.

What is the root cause of that problem?

The ValidationUtils.isValidRoomName method does not take into account accented Latin (including Spanish) characters.

What changes do you think we should make in order to solve the problem?

Extend the regular expression defined in REGEX.ROOM_NAME (CONST.js) to include:

\u{00c0}-\u{024f}\u{1e00}-\u{1eff}

Which will allow accented Latin characters, including Spanish, to be added to room names.

What alternative solutions did you explore? (Optional)

Allowing Spanish characters specifically. However, this would be a hacky temporary solution as the broader problem is that accented Latin characters are currently disallowed, which for example also includes French accented characters.

[melvin-bot[bot]]

📣 @samh-nl! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot[bot]]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[samh-nl]

Contributor details Your Expensify account email: h.sam.lw@gmail.com Upwork Profile Link: https://upwork.com/freelancers/~016c982fe69f86aff8

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01082e3b04cd3dad37

[melvin-bot[bot]]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[laurenreidexpensify]

@0xmiroslav do any of the proposals above look good?

[laurenreidexpensify]

@0xmiroslav bump^^

[0xmiros]

@samh-nl can you please share the source link of that regex which supports Latin characters?

[jayeshmangwani]

@0xmiroslav Do you have any feedback for my Proposal ?

[0xmiros]

@jayeshmangwani your proposal sounds good but checking to see if we can apply more general solution.

[jayeshmangwani]

your proposal sounds good but checking to see if we can apply more general solution.

@0xmiroslav It will be applicable for all the Spanish characters, and We have a similar regex already in use, À-ÿ in the below regex is used for Spanish small case and uppercase alphabets

https://github.com/Expensify/App/blob/8b7a65dcd36fa2b47ffb39c69f2cb294b94a7171/src/CONST.js#L1121

[0xmiros]

@jayeshmangwani ok great! As it's aligned with other name validation, it's fine to use à-ÿ for now. Before approving, can you please test all Spanish alphabets with this range?

[samh-nl]

@0xmiroslav Here is a regex tester with this regular expression, showing it's applicability: https://regex101.com/r/yvmwco/1 (multiline and global flags added for ease of reading)

It takes parts of Latin-1 Supplement, Latin Extended-A, Latin Extended-B and Latin Extended Additional.

The Spanish characters are contained within these standards, which I can validate manually.

[jayeshmangwani]

@jayeshmangwani ok great! As it's aligned with other name validation, it's fine to use à-ÿ for now. Before approving, can you please test all Spanish alphabets with this range?

@0xmiroslav tested with all Spanish alphabets

[0xmiros]

I like @jayeshmangwani's proposal. @samh-nl thanks for sharing links. For now, we're supporting only English and Spanish, a-zà-ÿ should be enough to fix this issue and it's already aligned with legal name validation regex. We can always revisit all regexes when we support more languages in the future. 🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @0xmiroslav You have been assigned to this job! Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account 🎉

Contributor - [$1000] Spanish character to room name shows the invalid name Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account 🎉

Reporter - [$1000] Spanish character to room name shows the invalid name

[laurenreidexpensify]

Sorry folks I broke the order here! Still waiting for @youssef-lr to sign off on the proposal https://github.com/Expensify/App/issues/21755#issuecomment-1618665262

[youssef-lr]

Looks good to me @laurenreidexpensify!

[melvin-bot[bot]]

📣 @0xmiroslav We're missing your Upwork ID to automatically send you an offer for the Reviewer role. Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[melvin-bot[bot]]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[jayeshmangwani]

@0xmiroslav PR is ready for review,

@laurenreidexpensify I have accepted these 2 offers (https://github.com/Expensify/App/issues/21755#issuecomment-1619735243 , https://github.com/Expensify/App/issues/21755#issuecomment-1619735320) before, should I ignore these 2 offers (https://github.com/Expensify/App/issues/21755#issuecomment-1623616663 , https://github.com/Expensify/App/issues/21755#issuecomment-1623616773)?

[jayeshmangwani]

@0xmiroslav bump for review

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.40-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/22345

If no regressions arise, payment will be issued on 2023-07-21. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@0xmiroslav] Determine if we should create a regression test for this bug.
• [ ] [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

@0xmiroslav can you complete the steps above? Thanks!

[laurenreidexpensify]

Waiting on @0xmiroslav for final steps here

[youssef-lr]

Not overdue. Waiting for checklist.

[laurenreidexpensify]

Payment Summary:

• External issue reporter - @jayeshmangwani $250, paid in Upwork
• Contributor that fixed the issue - @jayeshmangwani $1000, paid in Upwork
• Contributor+ that helped on the issue and/or PR - @0xmiroslav payment still outstanding as job not accepted in Upwork

[0xmiros]

• [x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/13994
• [x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/13994/files#r1277566817
• [x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [x] Determine if we should create a regression test for this bug.
• [x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

We added Spanish validation in unit test so no further regression test step is needed.

[0xmiros]

• Contributor was assigned on Jul 6
• C+ approved PR on Jul 10
• PR was merged on Jul 12 without any changes after C+ approval
• Jul 8, Jul 9 were weekend

This is eligible for timeline bonus

[0xmiros]

@laurenreidexpensify can you please hold my payment until further notice? I am working on some stuff due to recent measurements in my region. And update issue to Monthly. Thanks

[laurenreidexpensify]

Payment Summary Update:

• External issue reporter - @jayeshmangwani $250, paid in Upwork
• Contributor that fixed the issue - @jayeshmangwani $1000 AND $500 3 day bonus paid in Upwork
• Contributor+ that helped on the issue and/or PR - @0xmiroslav payment still outstanding $1000 AND $500 3 day bonus as per this comment

[laurenreidexpensify]

@0xmiroslav can we pay this yet?

[0xmiros]

@laurenreidexpensify still in discussion. Thanks for your patience. This issue can be updated weekly

[jayeshmangwani]

@laurenreidexpensify I have been paid for the reporter, but job is showing as Work in progress at Upwork , Can you please End contract from your side at Upwork?

[laurenreidexpensify]

@jayeshmangwani ah sorry for confusion. I paid everything in one contract, have closed out the other contract now.

[laurenreidexpensify]

@0xmiroslav are we good to pay this one yet?

[0xmiros]

@laurenreidexpensify let's close this for now. I am tracking locally.