'Confirm Task' button is not disabled after system throws 'error assigning task' error message

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open an existing chat/ start a new chat
Click on 'Actions' icon
Click on 'Assign task' button
Enter title > click on 'Next' button
Click on 'Confirm task' button
Expected Result:

Confirm task button shouldn't be clickable once the system throws an error saying 'error assigning task'

Actual Result:

Confirm task button is clickable once system throws an error

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.34-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/3640439f-6eab-4cc9-aa57-8ed47a75595f

https://github.com/Expensify/App/assets/43996225/0c201d16-ca5b-481b-8d8f-3c1befd596e4

Expensify/Expensify Issue URL: Issue reported by: @Natnael-guchima Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687797690671519

View all open jobs on GitHub

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

StevenKKC commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Confirm Task' button is not disabled after system throws 'error assigning task' error message.

What is the root cause of that problem?

App does not disable Confirm task button if there is a error in new task page.

What changes do you think we should make in order to solve the problem?

We should disable Confirm task button if there is a error.

    <FormAlertWithSubmitButton
        isAlertVisible={!_.isEmpty(errorMessage)}
+               isDisabled={!_.isEmpty(errorMessage)}
        message={errorMessage}
        onSubmit={() => onSubmit()}
        enabledWhenOffline
        buttonText={props.translate('newTaskPage.confirmTask')}
        containerStyles={[styles.mh0, styles.mt5, styles.flex1, styles.ph5]}
    />

What alternative solutions did you explore? (Optional)

None.

puneetlath commented 1 year ago

Unable to reproduce the error flow. Asking in slack.

puneetlath commented 1 year ago

Going to close for now since it's no longer reproducible. I asked @Natnael-Guchima to ping me in the slack thread if he's able to reproduce again and I'll reopen if so.

Expensify / App