[HOLD for #21910][$1000] Web - Bot recommendation message is shown on the placeholder of production app

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to production new expensify on web chrome (Happens on prod only) and login with User A
Create a new room in PUBLIC mode
Go to header of the room , copy the share code URL
On another web chrome login with User B and paste the URL so that User B can get access to the room
From User A, notice the chat composer placeholder. Instead of showing 'Write something', it shows concierge bot recommendation. Refreshing the page then solves the problem.

Expected Result:

'Write something' message should be shown on the placeholder of production app

Actual Result:

Bot recommendation message is shown on the placeholder of production app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.35-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/047b034d-9939-472c-8ce9-cd8ffc9759cb

https://github.com/Expensify/App/assets/93399543/d00227c7-77f0-4810-8a7b-893f29388794

Expensify/Expensify Issue URL: Issue reported by: @priya-zha Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688452510141429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01190afe684784e3f0
Upwork Job ID: 1676423042899935232
Last Price Increase: 2023-07-05

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[x] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[x] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

kadiealexander commented 1 year ago

Reproduced:

https://github.com/Expensify/App/assets/59587260/fb543dc6-93bd-441d-8227-403b3e21e1b9

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~01190afe684784e3f0

melvin-bot[bot] commented 1 year ago

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

alitoshmatov commented 1 year ago

Looks like this issue is related to this - https://github.com/Expensify/App/issues/21910. In mentioned issue, concierge is added to public rooms, when adding new user. That is why we see Ask me anything! placeholder, because in the code there is a logic where if one of the members is concierge that we will show this placeholder:

https://github.com/Expensify/App/blob/ecfcd8325d73851499f00399b14b8ae8e7f55f90/src/pages/home/report/ReportActionCompose.js#L354-L364

To conclude we can hold this for https://github.com/Expensify/App/issues/21910 .

We can also change the logic if it is not expected behavior to have this placeholder in public rooms which include concierge