Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.49k stars 2.84k forks source link

[HOLD for payment 2023-08-02] [$1000] Web - In new task page, share destination doesn't have subtitle text for 1 to 1 DM and group chat #22296

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to assign task
  2. Enter title and click next
  3. Choose an assignee
  4. Choose either 1 to 1 DM

Expected Result:

Selected share destination should have subtitle (contact method) shown below the user's display name

Actual Result:

Selected share destination does not have subtitle (contact method) shown below the user's display name for 1:1 DMs.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.36.4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/8b4d0116-0355-4e29-957f-154e568b8819

image (15)

Expensify/Expensify Issue URL: Issue reported by: @chiragxarora Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688485210604909

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014fbeac64e9814e82
  • Upwork Job ID: 1677046091547865088
  • Last Price Increase: 2023-07-13
joekaufmanexpensify commented 1 year ago

Added regression test issue above. BZ checklist is now complete, and all set to issue payment!

joekaufmanexpensify commented 1 year ago

@chiragxarora was assigned to this bug at 4:52 pm ET on 2023-07-18. PR was approved by @eVoloshchak on 2023-07-21 at 12:36 pm ET, which is under 72 hours. @bondydaa didn't merge it until 2023-07-24. However, since @eVoloshchak approved this PR in less than 72 hours, this still qualifies for a speed bonus.

joekaufmanexpensify commented 1 year ago

This means we need to pay:

joekaufmanexpensify commented 1 year ago

@chiragxarora $1,750 sent and upwork jobs ended! You were hired in Upwork twice (for PR and reporting), so I sent $1,500 in the PR job, and $250 in the reporting one.

joekaufmanexpensify commented 1 year ago

Upwork job closed.

joekaufmanexpensify commented 1 year ago

@eVoloshchak could you please request $1,500 and comment here once you have? Thanks!

eVoloshchak commented 1 year ago

Requested the payment via NewDot🎉

JmillsExpensify commented 1 year ago

Reviewed details for @eVoloshchak. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

joekaufmanexpensify commented 1 year ago

Great, thanks! Closing as this is now all set.