[HOLD for payment 2023-11-21][$1000] Offline - Create task in a room with admin only

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to two accounts, Alice and Bob, in two separate browser tabs.
2. Alice creates a workspace and invites Bob as a non-Admin member.
3. Bob goes to the #announce room for the new workspace.
4. Bob goes offline.
5. Alice goes to the #announce room for the new workspace, opens room settings, and under Who can post, sets Admins only.
6. Since Bob is offline, he does not receive an update that the room has become read-only for non-admins. Therefore, he can still attempt to create a task offline in the #announce room.

Expected result

When Bob comes back online, the task should appear "greyed out" with a "red brick road" error. Any actions Bob attempted to take on that task (such as leaving a reaction), should fail.

Actual Result:

The task appears to have been completed normally for Bob, unless he tries to create a thread with that task as the root, in which case he'll see a 404 page.

Workaround:

Don't do that, Bob!

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.39-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/1983e5a9-e67b-4a0f-9736-7fbea6a98fa5

https://github.com/Expensify/App/assets/43996225/7e1602b3-b70a-43ce-9722-c66a23fd0a93

Expensify/Expensify Issue URL: Issue reported by: @namhihi237 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689010436307099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01afb147c594f572e5
• Upwork Job ID: 1679478215688933376
• Last Price Increase: 2023-07-13
• Automatic offers:
• namhihi237 | Contributor | 26516237
• namhihi237 | Reporter | 26516238

[parasharrajat]

Just got back from Vacation, will check asap.

[parasharrajat]

I will an update tomorrow on this. Let's finalize this asap. I can see that things have changed since we started the PR.

[isabelastisser]

Hey @parasharrajat what's next here?

[parasharrajat]

Retesting it now.

[namhihi237]

Hi @parasharrajat @thienlnam I just tested on the main Currently on main: After the task is created with an error, the task report is not deleted when opening and leaving the task report.

https://github.com/Expensify/App/assets/39086067/5e602fc4-961a-4e25-88a6-122a1d627270

Fix version: In the task preview, we will show RGB. When RGB is clear we will clear the task preview and task report

https://github.com/Expensify/App/assets/39086067/d8e10b52-0f9e-4209-8812-6444f6a6d668

What do you think about this?

[parasharrajat]

This looks good to me @namhihi237. But we should also show an error on the Task report. In the fix video above, I can see that there is RBR dot on the task report but there is no error shown while it is open. It should have an error similar to report action.

[parasharrajat]

Let's get this wrapped up. Can you please update the PR and I will retest?

[namhihi237]

@parasharrajat yes, I updated the PR, please help to retest it.Thanks

[thienlnam]

This looks good to me @namhihi237. But we should also show an error on the Task report. In the fix video above, I can see that there is RBR dot on the task report but there is no error shown while it is open. It should have an error similar to report action.

Agreed with this, it should have an error on the task report so you can clear it there as well

[namhihi237]

@thienlnam Currently, in the task report, when creating an error the backend will return the error "Auth CreateTask returned an error" so we have 2 errors shown here. cc @parasharrajat , What do you think?

https://github.com/Expensify/App/assets/39086067/77f2fc59-0acf-4aa3-9058-0bd8790bbf7c

[thienlnam]

That's fine, it happens in other locations as well

[melvin-bot[bot]]

@parasharrajat, @thienlnam, @isabelastisser, @namhihi237 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@parasharrajat, @thienlnam, @isabelastisser, @namhihi237 Eep! 4 days overdue now. Issues have feelings too...

[thienlnam]

PR almost complete, couple last comments but should be merged next week

[namhihi237]

@isabelastisser PR already deploy production but the label of this issue does not add.

[namhihi237]

Hi @thienlnam can you help to change label and title for payment. Seem auto has an error. Thanks

[thienlnam]

Here's the linked PR https://github.com/Expensify/App/pull/26848

cc @isabelastisser This is ready for payment

[isabelastisser]

Payment summary:

📣 @parasharrajat Please request via NewDot manual requests for the Reviewer role ($1000) @namhihi237 issue reporter: $50 @namhihi237 Accepted proposal: $1000

Payments made in Upwork, all set!

[namhihi237]

@isabelastisser hi the issue report before i think it should be 250$ for reporter

[isabelastisser]

Thanks for the heads up, @namhihi237 ! I updated the payment amount in Upwork now.

[parasharrajat]

Payment requested as per https://github.com/Expensify/App/issues/22608#issuecomment-1828507508

[JmillsExpensify]

$1,000 approved for @parasharrajat based on this comment.