Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

[HOLD for payment 2023-10-13] 🟡 Implement a DraggableList for waypoints #22716

Closed neil-marcellini closed 1 year ago

neil-marcellini commented 1 year ago

Please follow the plan in the design doc: Implement a DraggableList for waypoints.

Issue OwnerCurrent Issue Owner: @twisterdotcom
hayata-suenaga commented 1 year ago

not overdue just assigned myself

hayata-suenaga commented 1 year ago

This is on hold

hayata-suenaga commented 1 year ago

This is on hold and has less priority.

melvin-bot[bot] commented 1 year ago

@hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

hayata-suenaga commented 1 year ago

The latest update here: https://expensify.slack.com/archives/C04878MDF34/p1692972677966979?thread_ts=1692752442.794829&cid=C04878MDF34

melvin-bot[bot] commented 1 year ago

@hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

hayata-suenaga commented 1 year ago

the latest update here: https://github.com/Expensify/react-native-x-draggable-list/pull/7#issuecomment-1699342985

hayata-suenaga commented 1 year ago

Holding the merge per this discussion

melvin-bot[bot] commented 1 year ago

@hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

hayata-suenaga commented 1 year ago

I put HOLD to the second-attempt PR for the "Current Location" feature per this Slack discussion

melvin-bot[bot] commented 1 year ago

@hayata-suenaga 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

hayata-suenaga commented 1 year ago

The latest discussion here

We have a design decision to make

melvin-bot[bot] commented 1 year ago

@hayata-suenaga Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 1 year ago

@hayata-suenaga Still overdue 6 days?! Let's take care of this!

hayata-suenaga commented 1 year ago

The PR is still being reviewed and worked on

melvin-bot[bot] commented 1 year ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

hayata-suenaga commented 1 year ago

also, this regression was potentially caused from the PR.

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.78-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-13. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 1 year ago

@hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

hayata-suenaga commented 1 year ago

Payment summary.

@DylanDylann and @situchan reviewed this PR by a SWM engineer.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

twisterdotcom commented 1 year ago

Apologies folks, who should I be paying here and how much? Is it $500 for @DylanDylann and @situchan?

hayata-suenaga commented 1 year ago

@twisterdotcom both please. This was a big PR and needed several C+'s eyes

DylanDylann commented 1 year ago

@twisterdotcom @hayata-suenaga It seems we have a mistake here, I didn't review this PR so I am not eligible for payment here 😄

situchan commented 1 year ago

There was only 1 C+ review. Other than efforts, I think original base price (1k) applies here as PR was raised 3 hrs before announcement.

twisterdotcom commented 1 year ago

Okay @hayata-suenaga so, $1k for @situchan and that's it?

twisterdotcom commented 1 year ago

bump @hayata-suenaga.

hayata-suenaga commented 1 year ago

@twisterdotcom yes $1k for @situchan please 🙇

twisterdotcom commented 1 year ago

Offer: https://www.upwork.com/nx/wm/offer/27434574

twisterdotcom commented 1 year ago

Paid $1000 to @situchan here: upwork.com/nx/wm/offer/27434574