[HOLD for payment 2023-07-26] [$1000] Attachments not shown for sender, stuck at 'Uploading attachment...'

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

• Open any chat (group or 1:1)
• Add an image attachment
• Uploading attachment... should show temporarily

Expected Result:

• After upload, other users should see the attachment
• After upload, the uploader should image attachment should show

Actual Result:

• After upload, other users can see the attachment ✅
• After upload, the uploader cannot see the image attachment ('Uploading attachment...' is still shown) ❌

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [?] iOS / native
• [?] iOS / Safari
• [?] MacOS / Chrome / Safari
• [?] MacOS / Desktop

Version Number: 1.3.39-5 and 1.3.38-7 Reproducible in staging?: Yes Reproducible in production?: Yes Issue reported by: Me Slack conversation: N/A

Uploader (jules) sees:

Other user sees:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019a63d2e48d9abd42
• Upwork Job ID: 1679142267668922368
• Last Price Increase: 2023-07-12

[melvin-bot[bot]]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Julesssss]

Hi @JmillsExpensify, do you recall anything unusual about the profile image file you used? I have only ever seen this issue on messages from you 😅

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attachments not shown for sender, stuck at 'Uploading attachment...'

What is the root cause of that problem?

Seems we are passing wrong value(undefined) here for prevVisibleMessageText Localize.translateLocal in the latest PR which seems breaking the flow for attachment. https://github.com/Expensify/App/blob/29ae9421d61c5a05e12408c258f64d4b65c3c2c4/src/libs/actions/Report.js#L248-L250 https://github.com/Expensify/App/commit/1a7bbcf0251a76c234b326b1fee2936e02d99d3e#diff-8afe5b71ee0436c21364148c86dadd640f2bff3e3d916addbb1f1f6f7e5b6a43R248-R250

What changes do you think we should make in order to solve the problem?

We need to correct the value we are passing. cc: @roryabraham prevVisibleMessageText = Localize.translateLocal(lastVisibleMessage.lastMessageTranslationKey);

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~019a63d2e48d9abd42

[melvin-bot[bot]]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[Julesssss]

FFS. Not again. Going back to Conor as he was the original assignee

[melvin-bot[bot]]

📣 @rushatgabhane Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot[bot]]

📣 @rushatgabhane We're missing your Upwork ID to automatically send you an offer for the Reviewer role. Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[melvin-bot[bot]]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[roryabraham]

My mistake, good find @Pujan92

[Pujan92]

@rushatgabhane PR is ready for review!

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.42-26 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/22836

If no regressions arise, payment will be issued on 2023-07-26. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter - @gadhiyamanan
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@rushatgabhane] Determine if we should create a regression test for this bug.
• [ ] [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Hey @conorpendergrast - @gadhiyamanan reported a similar issue (https://github.com/Expensify/App/issues/22762) 6-7 hours before this GH issue was created, and the PR here ended up fixing the issue he reported. I think that we should pay @gadhiyamanan the reporting bonus since he reportedthe issue first. Could you please send him an offer on this job for $250?

[conorpendergrast]

Sent! I'll pay that alongside everything else in this issue

[conorpendergrast]

Ok, it's two days past payday, sorry! Here's what I'm going to do:

• [x] External issue reporter - @gadhiyamanan: $250
• [x] Contributor that fixed the issue: @Pujan92: $1000 + 50% urgency bonus
• [x] Contributor+ that helped on the issue and/or PR : @rushatgabhane: $1000 + 50% urgency bonus (via NewDot)
• [x] Bonus appies? YES, adding 50% for the C and C+ Upwork job is here

[conorpendergrast]

@rushatgabhane Final step is the checklist, please! Then I'll do a regression test (if necessary) and I'll close this out

[conorpendergrast]

@rushatgabhane Bump on the checklist please. I'll be able to close this out after that!

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/22724

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22724#discussion_r1262931017

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required because it's a typo-ish.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Created a manual request https://staging.new.expensify.com/r/8593074213496497

This issue can be closed 🙇

[conorpendergrast]

Woo, thanks!

[JmillsExpensify]

Reviewed details for @rushatgabhane. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.