[HOLD Issue #309277][$1000] LHN - Chat that doesn't have a message does not disappears from the LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Scenario "empty DMs"

1. Go to https://staging.new.expensify.com/
2. Login with any account
3. Search for a user that you don't have any messages with and open the chat. Don't send any message
4. Navigate away from the conversation by clicking any other available conversation in the LHN list

Scenario "empty threads"

1. Go to https://staging.new.expensify.com/
2. Login with any account
3. Select any user
4. Select "Reply in Tread" option

Expected Result:

1. Conversation with no messages should disappear from LHN conversation list
2. Thread report is not displayed until the comment is posted

Actual Result:

1. Conversation that doesn't have any messages doesn't disappear from from LHN
2. Thread report is displayed when the comment is not posted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.37.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Scenario "empty DMs"

https://github.com/Expensify/App/assets/78819774/dacf6489-8f37-4f7f-99b7-dbadc42cb41f

Scenario "empty threads"

https://github.com/Expensify/App/assets/93399543/74a0a9f2-16d7-4194-a7bc-320ea8633dc7

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013fc034f8ebadf86c
• Upwork Job ID: 1681415083049984000
• Last Price Increase: 2023-08-01

[melvin-bot[bot]]

@alexpensify @cristipaval @rushatgabhane this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

[dukenv0307]

@rushatgabhane I just update some words to make it more clear, help to check again Update proposal

[alexpensify]

@rushatgabhane when you get a chance, can you please review the updated proposal? Thanks!

[rushatgabhane]

@dukenv0307 thank you, your proposal looks crisp! 🎀 👀 🎀 C+ reviewed https://github.com/Expensify/App/issues/22806#issuecomment-1670888065

[melvin-bot[bot]]

Current assignee @cristipaval is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[cristipaval]

The first API change is currently in review.

[dukenv0307]

We should hold this issue until api ready

[cristipaval]

It seems that this issue is going to be fixed by @srikarparsi's project. @srikarparsi Could you please confirm? Do you have an issue on which I could hold this one?

[srikarparsi]

Hey @cristipaval! Yes, this should be fixed by the Improving Threads Logic project. You can use that issue to hold this one :)

[alexpensify]

Thanks, since this is on hold, I'm moving to Weekly.

[cristipaval]

Thank you both! 🙇

[alexpensify]

Weekly Update: On Hold

[cristipaval]

As far as I saw lately, this is not reproducible anymore and the empty chats are hidden from the LHN.

[cristipaval]

@alexpensify could you confirm and close the issue?

[alexpensify]

I'm catching up from being OOO, I will test tomorrow.

[alexpensify]

Still on my testing list

[alexpensify]

Yeah, I confirmed too, and will close this GH.

[dukenv0307]

@alexpensify I think contributors should be eligible for compensation in this issue. The solution provided was valid at the time, contributors assigned and the process of reviewing the pull request had already begun. However, due to subsequent changes, the solution became outdated.

There were many precedents to this like here and here.

Thanks!

cc @rushatgabhane @cristipaval

[alexpensify]

@dukenv0307 - I'll review the feedback and follow up later this week.

[alexpensify]

Still on my review list

[alexpensify]

Thanks for your patience here. Since the examples shared here, there have been a few updates to the partial payment process. I need to ask a few questions and would like your opinions:

1. What compensation do you think is the percent due here for the work input here - 0, 25, 50, OR 100%?
2. Reasoning why has been shared here.

@dukenv0307 and @rushatgabhane - please reply, Thanks!

[dukenv0307]

@alexpensify Thanks for looking into this!

According to the precedents mentioned here and many others, the payout should be 100%. The work is almost complete here but unfortunately it's outdated due to changes outside of our control.

[alexpensify]

Thanks for sharing @dukenv0307!

@rushatgabhane - can you share some feedback or if you agree? Thanks!

[rushatgabhane]

@alexpensify I'm gonna ask this in C+ channel

https://expensify.slack.com/archives/C02NK2DQWUX/p1695651864238459

[Christinadobrzyn]

Also reached out to BZ about payment - https://expensify.slack.com/archives/C01SKUP7QR0/p1695743819720659

[alexpensify]

@rushatgabhane I should have included this before but there is a process for partial payments. The summary is:

Ask the C+ or contributor what compensation they think they’re due and ask them to provide reasoning why. Also ask them to present their compensation request as a percent of the job price where standard payments are 0, 25, 50 and 100%.

From there, I will review and plan accordingly. I'd still appreciate if you shared a percent here. Thanks!

[alexpensify]

Not overdue, waiting for feedback. @rushatgabhane when you get a chance can you share the percentage number? Thanks!

[cristipaval]

Just sharing my thoughts here:

• The C+ did review the proposals and jumped into the conversation, but there was no real code review or testing. 25% should be fine for them.
• The assigned contributor spent some time on the accepted solution and encountered some challenges. They raised them here, and there was some back and forth. Paying 100% is fair in this case.

[alexpensify]

Thanks, I will start this payment breakdown.

[alexpensify]

Here is the payment summary:

• External issue reporter N/A
• Contributor that fixed the issue @dukenv0307 $1000
• Contributor+ that helped on the issue and/or PR @rushatgabhane $250

Upwork Job: https://www.upwork.com/jobs/~01b0decd73ba4f11c0

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: This payment breakdown has been in discussion but here is the summary https://github.com/Expensify/App/issues/22806#issuecomment-1756471196

[alexpensify]

@dukenv0307 - I've sent a proposal via Upwork. Please accept and I can complete the process, thanks!

[dukenv0307]

@dukenv0307 - I've sent a proposal via Upwork. Please accept and I can complete the process, thanks!

@alexpensify accepted, thank you!

[JmillsExpensify]

$250 payment approved for @rushatgabhane based on BZ summary.

[alexpensify]

Everyone has been paid! I've completed the process in Upwork for @dukenv0307.