search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2023-10-23][$2000] Choosing group members change the search input and it's label style #22812

Closed kavimuru closed 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

1.Click on the FAB and create New group 2.Start adding the group members and notice the search input and it's label

Expected Result:

Choosing group members shouldn't change the search input and it's label style for better UX.

Actual Result:

Every time we choose a member we change the search input and it's label, because of the search input refocus

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.40-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

Screencast from 13-07-23 05_23_15.webm

https://github.com/Expensify/App/assets/43996225/358c55d1-b9d8-445f-8241-26c76b07f216

Expensify/Expensify Issue URL: Issue reported by: @Ahmed-Abdella Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689216766939829

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f1e32514bd8c7aa9
  • Upwork Job ID: 1681446377913671680
  • Last Price Increase: 2023-08-07
  • Automatic offers:
    • situchan | Reviewer | 27097976
    • s-alves10 | Contributor | 27097978
    • Ahmed-Abdella | Reporter | 27097981
situchan commented 1 year ago

@s-alves10 @situchan this does not persist focus on Invite members page that uses selectionList, right?

right. We can apply same logic if needed, but that page always not persisted focus from the beginning.

situchan commented 1 year ago

Oh I just noticed that refocus logic implemented in https://github.com/Expensify/App/pull/27497 and merged recently. So now this bug happens on selection list as well. @s-alves10 you may need to update your proposal again to cover these pages which use selection list.

situchan commented 1 year ago

So good timing of this issue to start

s-alves10 commented 1 year ago

Okay. I'll update soon

MonilBhavsar commented 1 year ago

So good timing of this issue to start

Right 👍

Okay. I'll update soon

Thank you! Looking forward to it. Would be great to avoid code deduplication i.e. not pass similar props and handle the logic in two different components in a similar way.

s-alves10 commented 1 year ago

@situchan @MonilBhavsar

Proposal

Updated

situchan commented 1 year ago

Would be great to avoid code deduplication i.e. not pass similar props and handle the logic in two different components in a similar way.

@s-alves10 does your proposal take this feedback into account?

s-alves10 commented 1 year ago

Both SelectionList and OptionsSelector have shouldFocusOnSelectRow props. I used them. I don't think deduplication is needed

situchan commented 1 year ago

Currently, there's no refocus logic on Invite new members page. https://github.com/Expensify/App/pull/27497 handled Members page only. I think we can fix it here.

@MonilBhavsar I am fine with updated proposal.

MonilBhavsar commented 1 year ago

Thank you @s-alves10 and @situchan for carrying this forward! Looks good to me 👍

melvin-bot[bot] commented 1 year ago

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

MonilBhavsar commented 1 year ago

Why the offers were not sent automatically Because it was Internal, may be 🤔

situchan commented 1 year ago

Why the offers were not sent automatically Because it was Internal, may be 🤔

@MonilBhavsar Now it's External & Help Wanted so unassign and reassign @s-alves10

melvin-bot[bot] commented 1 year ago

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 1 year ago

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] commented 1 year ago

📣 @Ahmed-Abdella 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

s-alves10 commented 1 year ago

@situchan

PR is ready for review https://github.com/Expensify/App/pull/29084

Ahmed-Abdella commented 1 year ago

Sorry @MonilBhavsar , @sonialiap but this issue was reported before changing the rate, it should be at 250$.

melvin-bot[bot] commented 1 year ago

🎯 ⚡️ Woah @situchan / @s-alves10, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

On to the next one 🚀

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.83-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-20. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.83-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-20. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

sonialiap commented 1 year ago

@situchan review + bonus = $3000 - paid ✔️ @s-alves10 fix + bonus = $3000 - offer sent @Ahmed-Abdella report = $250 - new offer sent with the correct amount

Ahmed-Abdella commented 1 year ago

@sonialiap I accepted the offer, Thanks.

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.84-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-23. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.84-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-23. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

sonialiap commented 1 year ago

I'm OOO Oct 16-23. Adding leave buddy

Status: waiting to issue payment https://github.com/Expensify/App/issues/22812#issuecomment-1765319825

MonilBhavsar commented 1 year ago

Bumping to weekly as payment is due next week

bfitzexpensify commented 1 year ago

Flicking this one back to daily so that it's in the right spot in my k2 dashboard

bfitzexpensify commented 1 year ago

Due 10/23

MonilBhavsar commented 1 year ago

Payment is due today. @situchan could you please take a look at the checklist

MonilBhavsar commented 1 year ago

False comment, Melvin

sonialiap commented 1 year ago

@situchan review + bonus = $3000 - paid ✔️ https://github.com/Expensify/App/issues/22812#issuecomment-1763272663 @s-alves10 fix + bonus = $3000 - paid ✔️
@Ahmed-Abdella report = $250 - paid ✔️

sonialiap commented 1 year ago

@situchan last step is to do the checklist. I scrolled through the issue and I don't think it's been filled out yet but let me know if I missed it

MonilBhavsar commented 1 year ago

@situchan could you please take a look at the checklist. Thanks!

situchan commented 1 year ago

There were several changes on this behavior but the original root cause existed from the beginning as it's web's default behavior to blur element when another one is clicked. So no regression.

This is minor UI issue so I don't think it's worth adding to regression test which should run on every deploy. And the refactor will not likely to happen again so the fix won't be reverted.

MonilBhavsar commented 1 year ago

I would say we should add regression test, as we usually update callback functions with lists and could probably cause regression

situchan commented 1 year ago

Regression Test Proposal

Case 1:

  1. Go to FAB > Start chat
  2. Focus on search input if not focused
  3. Select multiple users by tapping "Add to group" button
  4. Deselect users again by tapping ✅ button
  5. Verify that the style of search input and label doesn't change

Case 2:

  1. Go to FAB > Request money
  2. Input any amount in manual tab and tap Next
  3. Focus on search input if not focused
  4. Select multiple users by tapping "Split" button
  5. Deselect users again by tapping ✅ button
  6. Verify that the style of search input and label doesn't change

Case 3:

  1. Go to Settings > Workspaces > any workspace > Members
  2. Focus on search input if not focused
  3. Select/deselect users by tapping on each row or its ✅
  4. Verify that the style of search input and label doesn't change
  5. Click on Invite button to go Invite members page
  6. Select/deselect users by tapping on each row or its ✅
  7. Verify that the style of search input and label doesn't change
MonilBhavsar commented 1 year ago

And also Workspace settings > Members page please

situchan commented 1 year ago

Updated.

melvin-bot[bot] commented 1 year ago

@sonialiap, @MonilBhavsar, @bfitzexpensify, @situchan, @s-alves10 Whoops! This issue is 2 days overdue. Let's get this updated quick!

sonialiap commented 1 year ago

New regression test addition submitted