[HOLD for payment 2024-03-08] Implement Tiered Business Bank Account flow

[mountiny]

This is an implementation issue for the Tiered bank account setup flow in NewDot internal project, design doc can be found here.

All the details will be added to this issue once the implementation will be ready to start.

cc @gedu

[melvin-bot[bot]]

Current assignee @anmurali is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[gedu]

Hey Edu from Callstack

[anmurali]

Detailed design is in review

[anmurali]

Still in review. @gedu there's several sections (Manual tests, automated tests, rollout plan) that you still need to finish for this doc to be done!

[anmurali]

@gedu bump on this. Were you able to get those sections completed?

[anmurali]

Asked for an update here

[gedu]

I've provided more comprehensive information on how to approach this UI/UX migration, concentrating on elaborating on new components and how to manage navigation, states, and so forth. I initiated the Manual Test section, and I'm only left with the final step. Later, I'll proceed with Automated tests.

[gedu]

Added one more step, and asked some questions about some steps

[gedu]

@anmurali I added the Manual, Automated and Rollout sections. There are some questions.

[gedu]

@anmurali Did you have the chance to review the new sections?

[anmurali]

Not yet @gedu - I think you also need all the same engineering reviewers to go back through it. So tagging @ryanschaffer @johnmlee101 @joekaufmanexpensify and @joelbettner on that. Please skim through your comments in the doc and make sure we addressed them and resolve? Also we added manual and automated tests, a rollout plan for your review. https://docs.google.com/document/d/1t8_Fn93LSSU4gG4z7WRt8IFcpSGK4TIe4QamdcTXjxE/edit?usp=sharing

[anmurali]

No update.

[anmurali]

We are now implementing this as part of #wave6-collect-category-tag-submitters-07nov23

[gedu]

I start creating the issues to start working on this

[gedu]

Issues created and added into the Document

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @gedu, @anmurali eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[anmurali]

Tracking the first part of this update here

[mountiny]

Assigned @nkuoch and @MariaHCD so they get the credits for reviewing the PR as well 🙌 thanks for help!

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[joekaufmanexpensify]

I have this one where the android app is crashing when setting up a VBA that feels related to this. LMK if you agree!

[mountiny]

@joekaufmanexpensify The PR was just merged and the issue was reported 2 weeks ago. Could Applause try to retest now after the refactor?

[joekaufmanexpensify]

Ah, interesting. I didn't realize that was the only PR for this one. I see mine is actually a dupe of another too. So going to close in favor of that one.

[trjExpensify]

👋 coming from this issue.

I suspect some regression test scripts need to be passed over to the Applause to update/add/remove based on the new refactored flow. Who's taking care of that for this project? Let's make sure when this is shipped we do that, so we don't have outdated flows and expected behaviour for the VBBA flow.

[mountiny]

I have shared this script with applause when this was deployed to staging. In Slack, discussing here.

[trjExpensify]

Amazing, thanks!

[shubham1206agra]

These are the PRs apart from the main one that I reviewed (Main PR https://github.com/Expensify/App/pull/34498)

• https://github.com/Expensify/App/pull/30415
• https://github.com/Expensify/App/pull/30426
• https://github.com/Expensify/App/pull/30576
• https://github.com/Expensify/App/pull/31121
• https://github.com/Expensify/App/pull/30924
• https://github.com/Expensify/App/pull/31812
• https://github.com/Expensify/App/pull/32709

[shubham1206agra]

@mountiny Can you post about payment here as we discussed?

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

This project spanned couple of months and lots of discussions along the way, testing and QA as well as a follow up PRs. I propose we will pay $5000 for this project to @shubham1206agra given the PRs listed. They have also been removed from the c+ team for some time so they can focus on these changes which meant they were not assigned more work.

Thats why I think the price is appropriate for their work

[akinwale]

@mountiny As discussed, here are the PRs I have reviewed for the project.

Main PR https://github.com/Expensify/App/pull/34498

Follow-up PRs https://github.com/Expensify/App/pull/36472 https://github.com/Expensify/App/pull/37025 https://github.com/Expensify/App/pull/37032

Regressions fixed by external contributors https://github.com/Expensify/App/pull/36573 https://github.com/Expensify/App/pull/36585 https://github.com/Expensify/App/pull/36589 https://github.com/Expensify/App/pull/36621 https://github.com/Expensify/App/pull/36763

[mountiny]

As discussed before for @akinwale here, we have proposed $1500 for the review of the PR and since he has helped with all the regressions too, I think no penalty should be imposed as it was large PR.

So $2000 for @akinwale for their help on this project and the follow up issues.

[mountiny]

Summary:

• @shubham1206agra $5000 for shepherding this entire project as C+
• @akinwale $2000 for reviewing the main PR and helping with the follow up issues as C+

The breakdown of the PRs is above

@anmurali this is ready for payment

[melvin-bot[bot]]

Payment Summary

[Upwork Job]()

• Contributor: @gedu is from an agency-contributor and not due payment
• ROLE: @akinwale paid $(AMOUNT) via Upwork (LINK)
• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@anmurali)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[anmurali]

Offers sent to @akinwale (here) and @shubham1206agra (here)

[akinwale]

Offers sent to @akinwale (here) and @shubham1206agra (here)

@anmurali Accepted. Thanks.

[shubham1206agra]

@anmurali Can you hold my payment temporarily as per https://expensify.slack.com/archives/C02NK2DQWUX/p1710150138788529?

[anmurali]

Yes. @shubham1206agra - ping here when you're ready for us to process it. @akinwale is paid.

[shubham1206agra]

@anmurali, I have discussed this internally. You may close this issue as I am keeping track of payment internally and will ask to pay once the issue is resolved. Just write in the payment summary that I have not been paid yet.

[shubham1206agra]

@anmurali You can process payment here now.

[shubham1206agra]

@anmurali Bump on the above.

[shubham1206agra]

@anmurali Bump for the payment.

[shubham1206agra]

@anmurali Bump here.

[anmurali]

Paid.