Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

[HOLD for payment 2023-09-06] [$1000] Mweb – Assign Task – Mention options hides behind header. #22930

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open any " Assign Task " chat.
  2. Type “@” in composer, so that options appear.
  3. Notice that the first option hides behind header.

Expected Result:

Options should not hide, infect adjust itself according to the space.

Actual Result:

Mention options hide behind header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.40-5 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/138ac274-f9ad-4fea-a11c-59f23ec14089

Expensify/Expensify Issue URL: Issue reported by: @usmantariq96 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689313870564749

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0132b9832a42192981
  • Upwork Job ID: 1681653446268710912
  • Last Price Increase: 2023-08-02
kevinksullivan commented 1 year ago

Paid @usmantariq96 , waiting on @allroundexperts

allroundexperts commented 1 year ago

I'll be paid through the App @kevinksullivan. Can you please write a payment summary?

kevinksullivan commented 1 year ago

Payment summary:

kevinksullivan commented 1 year ago

@anmurali for newdot payment

kevinksullivan commented 1 year ago

Anu doesn't do this, so looping in @JmillsExpensify

allroundexperts commented 1 year ago

Checklist

  1. This was a real edge case which existed since the beginning of this feature. As such, I wasn't able to pinpoint a specific PR.
  2. Again, I think a Slack discussion would be redundant here because of this bug being a real corner case.
  3. For regression test as well, I think its not worth adding this case as it might not effect any user at all. However, if we disagree, following are the test steps.

Regression test

  1. Open staging website on any device whose height is less than 360px.
  2. Go to any chat and type “@” in composer, so that options appear.
  3. Verify that the mention options don't hide behind the chat header.

Do we 👍 or 👎?

kevinksullivan commented 1 year ago

Looks good to me, just waiting on @JmillsExpensify for payment

melvin-bot[bot] commented 1 year ago

@JmillsExpensify, @AndrewGable, @kevinksullivan, @allroundexperts, @robertKozik Eep! 4 days overdue now. Issues have feelings too...

kevinksullivan commented 1 year ago

closing issue, just waiting on jason

JmillsExpensify commented 1 year ago

$1,000 payment approved for @allroundexperts based on BZ summary.