Closed kbecciv closed 1 year ago
Triggered auto assignment to @JmillsExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are ✅)Split Bill - Page Freezes After Hitting the Split bill Button
When splitting bill, we collected user email, mapped them and put into the params, the problem is since we migrated to use accountID, we won't show userLogin (email), if we didn't have any interactions with them, so their emails are undefined.
That's why our app will be crashed, because we're trying to access undefined value in here and here
Since our backend still validate the email, we can add a validation on FE, if we couldn't find user email then we should show error text and prevent user from splitting.
Incase we still allow user to split money with the user that they've never interacted with, we should update our BE to remove email validation (since we used accountID), and replace email with accountID in here and here For example:
if (email === currentUserEmail) {
return;
}
Should be changed to:
if (accountID === currentUserAccountID) {
return;
}
N/A
@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
I'm not able to reproduce this one.
📣 @jo1290! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
@JmillsExpensify When splitting bill among many users this issue occurs, try it in large group with many users.
📣 @jo-ui! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: jhon.benex@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01fe71dd923c718f93
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?
Still not able to reproduce this. Most recently tried on iOS / Safari.
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
@JmillsExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Testing again. Wasn't reproducible in Mac OS / Safari. Closing.
Split bill - App crashing when make a split bill in a group chat with a new users
In the method - createSplitsAndOnyxData
in IOU.js
we are using participant.login
value at few places.
When we create a new user using email while creating group, the value for login
property is undefined.
And the error is saying that we can't have undefined as a value for that.
When we create a new user, the value for text
in participants
(in createSplitsAndOnyxData
method) has same value as the email/phone that was used to create the account.
We can use that on the places mentioned above -
participant.login || participant.text
In this way we will always prefer the login value and in case new user (where login is undefined) we will take text
as a value.
@JmillsExpensify This issue is still reproducible. Please consider it.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Split bill amount and continue without freezing.
Actual Result:
Hitting the split bill button causes the page to freeze.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.40-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/61641581-93a5-4735-a97b-cc05dfa0ec99
https://github.com/Expensify/App/assets/93399543/34a26ee3-d385-4ad2-82e8-620fbbb78df0
Expensify/Expensify Issue URL: Issue reported by: @jo-ui Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689354587381659
View all open jobs on GitHub