Closed lanitochka17 closed 1 year ago
Triggered auto assignment to @mallenexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are ✅)Moving through the split bill participants using arrows and pressing enter leads to unintuitive behavior.
There is a distinction between the hovered item (which you can change using arrows and is highlighted with a lighter background) and the focused item (highlighted with a border).
Pressing enter results in the toggling of both users. This is not intuitive as you only expect to toggle one user at a time.
Option 1. We should change the focused item also when moving through the participants using the arrows, to ensure that they are the same. Option 2. Blur the focused item when moving using the arrows.
N/A
Consider to apply hold https://github.com/Expensify/App/issues/12668 to this issue
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
Thanks @dukenv0307 , I'll dig in more soon, not a big priority since it might be on hold pending
@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...
@cristipaval , do you think this should be put on hold pending the below, it looks like you're leading that.
@mallenexpensify the thing is that I am not sure this is an issue. See this Slack thread for more info.
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
@mallenexpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
This issue has not been updated in over 14 days. @mallenexpensify eroding to Weekly issue.
I'm going to close this since it has to do with arrow keys and we haven't decided to optimize the app for keyboard nav. Also, as @cristipaval pointed out, Mills comment from 7 months ago was keep punting 🏈
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Preconditions:
Expected Result:
Moving through the "Split bill" participants with the help of arrows should be smooth and with a clear logic for the user
Actual Result:
When a user in the "Split bill" members menu clicks on any user from the "Split with" list and tries to use the arrows to navigate through the users using the selected/deselected(Enter) function, there are random jumps through the users when you press Enter
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.44.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/2e4cf351-8fd9-45d5-9806-f9c4445d2ef4
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:
View all open jobs on GitHub