Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Split Bill - Moving through the Split participants is done by jumping when using the arrows #23398

Closed lanitochka17 closed 1 year ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Preconditions:

  1. You must be logged in
  2. At least 1 group with 4 or more members must be created Steps:
  3. Open https://staging.new.expensify.com/
  4. Choose any group with 4 or more members
  5. Click on the + button in the compose box.
  6. Click on "Split bill" in the action menu
  7. Enter any amount of currency
  8. Click on "Next" button
  9. Click on any participant from the "Split with" list
  10. Use the arrows to move through the list of users and apply selected/deselected with "Enter"

Expected Result:

Moving through the "Split bill" participants with the help of arrows should be smooth and with a clear logic for the user

Actual Result:

When a user in the "Split bill" members menu clicks on any user from the "Split with" list and tries to use the arrows to navigate through the users using the selected/deselected(Enter) function, there are random jumps through the users when you press Enter

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.44.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/2e4cf351-8fd9-45d5-9806-f9c4445d2ef4

Expensify/Expensify Issue URL:

Issue reported by: Applause- Internal Team

Slack conversation:

View all open jobs on GitHub

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

samh-nl commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Moving through the split bill participants using arrows and pressing enter leads to unintuitive behavior.

What is the root cause of that problem?

There is a distinction between the hovered item (which you can change using arrows and is highlighted with a lighter background) and the focused item (highlighted with a border).

Pressing enter results in the toggling of both users. This is not intuitive as you only expect to toggle one user at a time.

What changes do you think we should make in order to solve the problem?

Option 1. We should change the focused item also when moving through the participants using the arrows, to ensure that they are the same. Option 2. Blur the focused item when moving using the arrows.

What alternative solutions did you explore? (Optional)

N/A

dukenv0307 commented 1 year ago

Consider to apply hold https://github.com/Expensify/App/issues/12668 to this issue

melvin-bot[bot] commented 1 year ago

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

mallenexpensify commented 1 year ago

Thanks @dukenv0307 , I'll dig in more soon, not a big priority since it might be on hold pending

melvin-bot[bot] commented 1 year ago

@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

mallenexpensify commented 1 year ago

@cristipaval , do you think this should be put on hold pending the below, it looks like you're leading that.

cristipaval commented 1 year ago

@mallenexpensify the thing is that I am not sure this is an issue. See this Slack thread for more info.

melvin-bot[bot] commented 1 year ago

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 year ago

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 year ago

@mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 1 year ago

@mallenexpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

melvin-bot[bot] commented 1 year ago

This issue has not been updated in over 14 days. @mallenexpensify eroding to Weekly issue.

mallenexpensify commented 1 year ago

I'm going to close this since it has to do with arrow keys and we haven't decided to optimize the app for keyboard nav. Also, as @cristipaval pointed out, Mills comment from 7 months ago was keep punting 🏈