Closed kbecciv closed 10 months ago
but similar in both ios and android
Yup. that sounds good to me.
If agreed We can make this change specific to ios only like this
That code block looks good to me.
Camera | Microphone |
---|---|
Do we agree on the copy 👍 or 👎, if yes can i get spanish copy here or should i ask for translated copy in slack?
cc @mallenexpensify @chiragsalian @situchan
Yes, that's looks good to me @ishpaul777
Hmm copy mostly LGTM. This part reads weird to me,
Please enable via Settings..
Shouldn't it instead be
Please enable it via Settings..
or
Please enable access in Settings..
or something similar. Thoughts @mallenexpensify? Or is the copy fine as is?
Let's leave the copy as-is, I think it reads well-enough. @ishpaul777 please add a period to the end of each of the sentences, thx.
Cool works for me, i think spanish copy is still needed. I'll ask on slack to translate these,
Enable Camera Access We need access to your camera to complete bank account verification. Please enable via Settings > New Expensify.
Enable Microphone Access We need access to your microphone to complete bank account verification. Please enable via Settings > New Expensify.
Asked here
Spanish translations:
Permiso para acceder a la cámara Necesitamos acceso a tu cámara para completar la verificación de tu cuenta de banco. Por favor habilita los permisos en Configuración > Nuevo Expensify.
Permiso para acceder al micrófono Necesitamos acceso a tu micrófono para completar la verificación de tu cuenta de banco. Por favor habilita los permisos en Configuración > Nuevo Expensify.
From the PR, @ishpaul777 will be out a couple days
I apologize for the unexpected turn of events, but I have to travel urgently for the next two days due to an emergency. I will make sure to complete this over the weekend. I sincerely apologize for any inconvenience this delay may cause.
@mallenexpensify for double confirmation of above item in author checklist do we need to capitalize each word in header title as in approved copy?
Good catch @ishpaul777 , I believe we recently made a change for capitalization . Please have the titles be
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
PR not merged yet. False alarm
This issue has not been updated in over 15 days. @chiragsalian, @mallenexpensify, @zanyrenney, @ishpaul777, @situchan eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
PR deployed yesterday, looks like automation failed. @mallenexpensify can you please switch label to weekly again
PR deployed to production 4 days ago, updated title to reflect payment is due the 21st. Updated to Weekly too.
BZ Checklist: No regression but incorrectly implemented from the beginning. I don't think this is worth adding to regression test suite
Reporter: @DinalJivani paid $250 via Upwork
Contributor: @ishpaul777 paid $500 via Upwork ($1k payment then $500 refund)
Contributor: @allroundexperts due $500 via NewDot
Contributor+: @situchan paid $1000 Upwork. (two $500 payments)
Above is a lil wonky, but, once the $500 refund from @ishpaul777 is confirmed we'll be all set. More context from https://github.com/Expensify/App/issues/23421#issuecomment-1777512421 to https://github.com/Expensify/App/issues/23421#issuecomment-1777527189
@situchan , can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01adeea47f2373964b
Accepted thanks
Hii @mallenexpensify, can you please pay @allroundexperts 500$ for their help in testing i will refund 500$ if you have paid to me already
updated payment post above Once I confirm @ishpaul777 's refund I'll close (and after double checking if we need/want a regression test for this).
Refunded, @mallenexpensify can you please check and confirm..
Thanks @ishpaul777 , confirming.
I'm going to agree with you that we don't need a regression test @situchan cuz someone would have to manually go in and change the code from Mic > Camera which I can't see that ever happening.
Payment breakdown above is updated.
$500 payment to @allroundexperts based on this comment.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Action Performed: Go to phone settings Turn off Microphone permission.
Expected Result:
It should show Alert for Microphone permission.
Actual Result:
t shows Camera permission alert instead of microphone permission
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.42-26 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/f1171187-f0ae-4db4-89f4-4cc647426f25
Expensify/Expensify Issue URL: Issue reported by: @DinalJivani Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689948082634299
View all open jobs on GitHub
Upwork Automation - Do Not Edit