[HOLD for payment 2023-09-27] [$1000] mWeb - 2FA - The screen jumps when deleting invalid code

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to http://staging.new.expensify.com/
Login into the account
Tap the profile avatar
Select Security > Two-factor authentication
Copy or download recovery codes
Tap the "Next" button
Enter an invalid code
Delete the code

Expected Result:

The code input stays on focus and there are no unusual jumps

Actual Result:

The screen jumps when removing digits

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.45-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/e0ee3b91-6a9c-4e7d-8bc4-c891c4947366

Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0127543ad8babfd9a3
Upwork Job ID: 1684832010423627776
Last Price Increase: 2023-09-07

eVoloshchak commented 1 year ago

@Christinadobrzyn, it's external, I'll post a review today Apologies for the delay everyone

eVoloshchak commented 1 year ago

Summary:

This is a known bug in Mobile Chrome. It was reported a year ago, there seems to be no activity or plans to resolve it.

Since this is pretty severe and will not be fixed in Chrome soon, I think we should apply a workaround.

@ydhandha's proposal is to set textInput's type the only type that isn't affected: type="search". The downside is, this will negatively affect accessibility
@ishpaul777's proposal is passing multiline=true to the textInput, which prevents the password manager bar from rendering

I think we need to fix this for all inputs throughout the app. The bug is present for all numeric inputs, not just the magic input (not the screen jumping, but the password manager bar is present while it shouldn't)

ishpaul777 commented 1 year ago

In my opinion, i dont think applying workaround to all of numeric inputs (that does not efffect UX by rendering password bar) is necessary considering the accessibility tradeoffs, as both are merely workaround and root cause is unfixable. I would recommend selectively applying the workaround to only input that's causing bad UX like Magiccodeinputs on 2fa screen.

melvin-bot[bot] commented 1 year ago

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Current assignee @eVoloshchak is eligible for the External assigner, not assigning anyone new.

ydhandha commented 1 year ago

@eVoloshchak, Thank you checking the proposal I have added. I would like to add the point in the reference to what you have mentioned here:

@ydhandha's proposal is to set textInput's type the only type that isn't affected: type="search". The downside is, this will negatively affect accessibility

Firstly, even if we don't pass the type explicitly, it will be type="text" as a default
In regards to accessibility, if you may check the same, there is hardly a difference in terms of using the type search or the default one type text which is in place currently and also that we do have all the required logic in place for the input that is being generated but surely, if you have any specific thought on impacting accessibility if we use this, I'd be eager to hear it from you
The function that I have suggested to create is common and can be used across the platform as needed, adding any attribute to element(s) and thus not bound to 2FA
Lastly, as I have mentioned in most of my previous comments as well that by passing type search, will not render the password manager bar and the same is required to fix our issue

Furthermore, if we use multiline true it will convert into textarea, I believe it will impact the accessibility and screenreaders and for the same below are the differences:

Multiline Text: is specifically designed for multiline text input. It allows users to enter and edit larger amounts of text, such as paragraphs, comments, or messages.</p> </li> <li> <p>Screen Readers: Screen readers typically announce <textarea> elements as "edit boxes" or "text areas," indicating to users that they can enter multiple lines of text.</p> </li> <li> <p>Assistive Technology: Users who rely on screen readers or other assistive technologies might find <textarea> more intuitive for longer text input.</p> </li> <li> <p>Resizing: Users can often resize the <textarea> box to suit their preferences or accommodate their content.</p> </li> </ul> <p>============== Input:</p> <ul> <li> <p>Single-Line Text: input elements are primarily used for single-line text input, such as usernames, emails, search queries, or short descriptions.</p> </li> <li> <p>Screen Readers: Screen readers announce <input> elements differently, often indicating the type of input expected</p> </li> <li> <p>Compact: For single-line input, <input> elements tend to be more compact and visually fit well in various layouts.</p> </li> <li> <p>Specific Input Types: Different type attributes of <input> can be used to provide specialized input fields, such as email, number, search, and more.</p> </li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ishpaul777"><img src="https://avatars.githubusercontent.com/u/104348397?v=4" />ishpaul777</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Input or textarea both are built for taking text from user, we by design accepts only one number so user won't be able to enter multiline text or any other text other than a single digit. As you have said text-area are resizable but resizing to text input is disabled by default in the app, Screen readers might associate <code>type=search</code> to a search input which I believe is a relatively bigger tradeoff for accessibility than replacing input from textarea.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ydhandha"><img src="https://avatars.githubusercontent.com/u/69626304?v=4" />ydhandha</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Yes, that's what I am trying to highlight in here. Since we have everything in place that we require, we can simply change the type to search but since, you have provided to use multiline which converts input to textarea, I have checked the same on my local using multiline prop whilst using the screen reader(NVDA) and below is the output as mentioned:</p> <p><strong>Input (using: type="search"):</strong></p> <ul> <li>Screen reader reads --- 'Edit Blank" </li> <li>No issue on accessing previous / next / tapped or clicked input and screen reader will read the text as well as if it is blank will read the same as above</li> <li>Even for input type text or any other type it still reads the same</li> </ul> <p><strong>Textarea (using: multiline prop)</strong></p> <ul> <li>Screen reader reads --- "Edit Multiline Blank" </li> <li>Because we are using textarea, screen reader reads the above</li> <li>No issue on accessing previous / next / tapped or clicked input and screen reader will read the text as well as if it is blank will read the same as above</li> </ul> <p>Furthermore you may check the above using screen readers for checking both the scenario as well as for the accessibility and I would suggest if required, not only on our react-app but you may check the screen readers anywhere(<em>even a raw file which consists of simply textarea and input with any type</em>) to compare how screen reader will read for a user for a textarea as well as for an input.</p> <p>To state further - Even if we use aria-label attribute which is, specifically, for screen reading, in the end(as a suffix), it would still reads the "Edit Blank" for an input and "Edit Multiline Blank" for textarea specifically in a case where no placeholder value is passed otherwise it would read the placeholder value as well</p> <p>Example: Consider aria-label="Add OTP here" and we are using textarea and input</p> <p><strong>Screen reader Output for Input:</strong> Add OTP here Edit Blank <strong>Screen reader Output for Textarea:</strong> Add OTP here Edit Multiline Blank</p> <p>I hope I have cover everything in here to explain how it will work in both the scenario.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/melvin-bot[bot]"><img src="https://avatars.githubusercontent.com/in/179547?v=4" />melvin-bot[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/eVoloshchak"><img src="https://avatars.githubusercontent.com/u/9059945?v=4" />eVoloshchak</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Re-posting summary from my comment above:</p> <blockquote> <p>This is a <a href="https://support.google.com/chrome/thread/167858494/password-bar-above-keyboard-on-android-phone-always-there?hl=en">known bug in Mobile Chrome</a>. It was reported a year ago, there seems to be no activity or plans to resolve it. Since this is pretty severe and will not be fixed in Chrome soon, I think we should apply a workaround.</p> </blockquote> <p>Testing this with a screen reader, having it say "Edit text. Search field" is better than "Text Area", so @ydhandha's proposal is better from an accessibility standpoint (but it depends on the specific screen reader I'd imagine)</p> <p>I think we should proceed with @ydhandha's <a href="https://github.com/Expensify/App/issues/23575#issuecomment-1690485081">proposal</a>. Changing textinput to a textarea as suggested by @ishpaul777 is a much bigger change and it could potentially introduce some regressions, since there are differences in how different devices/browsers handle textinput and textarea.</p> <p>🎀👀🎀 C+ reviewed!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/melvin-bot[bot]"><img src="https://avatars.githubusercontent.com/in/179547?v=4" />melvin-bot[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Triggered auto assignment to @hayata-suenaga, see <a href="https://stackoverflow.com/c/expensify/questions/7972">https://stackoverflow.com/c/expensify/questions/7972</a> for more details.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/hayata-suenaga"><img src="https://avatars.githubusercontent.com/u/98560306?v=4" />hayata-suenaga</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>I'm focusing on Wave 5 right now, but I'll come back to this issue to review proposals later this week 🙇 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/melvin-bot[bot]"><img src="https://avatars.githubusercontent.com/in/179547?v=4" />melvin-bot[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/hayata-suenaga"><img src="https://avatars.githubusercontent.com/u/98560306?v=4" />hayata-suenaga</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>@ydhandha </p> <blockquote> <p>This above strategy certainly targets to solve the issue on platform-specific rather than changing it globally as well as this created function can be imported in other cases where, we may want to use the same to pass some custom attribute.</p> </blockquote> <p>I like only applying the text input type change to web, but creating a platform specific files for this seems a little bit overwork 🤔 </p> <p>Anyway, I think setting attribute to native text input through <code>useRef</code> won't affect iOS and Android native text input components... maybe?</p> <p>Anyway, let's go with your proposal 🎉 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/melvin-bot[bot]"><img src="https://avatars.githubusercontent.com/in/179547?v=4" />melvin-bot[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($1000)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/melvin-bot[bot]"><img src="https://avatars.githubusercontent.com/in/179547?v=4" />melvin-bot[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>📣 @ydhandha You have been assigned to this job! Please apply to the <a href="https://www.upwork.com/jobs/~0127543ad8babfd9a3">Upwork job</a> and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: <a href="https://github.com/Expensify/App/blob/main/CODE_OF_CONDUCT.md">Code of Conduct</a> | <a href="https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md">Contributing</a> 📖</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Christinadobrzyn"><img src="https://avatars.githubusercontent.com/u/51066321?v=4" />Christinadobrzyn</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Hey @ydhandha let us know when you have a PR for review! </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ydhandha"><img src="https://avatars.githubusercontent.com/u/69626304?v=4" />ydhandha</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Hey @hayata-suenaga / @Christinadobrzyn ,</p> <p>Could you help me with the Upwork Job link? I am seeing job is not available. Neither am I seeing invitation nor can I apply since Job is no longer available. So I believe, once I receive the invitation / I am able to apply, I can work further. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/eVoloshchak"><img src="https://avatars.githubusercontent.com/u/9059945?v=4" />eVoloshchak</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>@ydhandha, it's normal, the upwork job has just expired. You can go ahead with raising the PR, usually, the whole upwork process is finalized before payment is due, long after the PR was merged We treat GitHub as the only source of truth, so as long as you're assigned to the issue on GitHub - you're hired and can create the PR</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ydhandha"><img src="https://avatars.githubusercontent.com/u/69626304?v=4" />ydhandha</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>@eVoloshchak, Thank you for providing details. </p> <p>I'll create the PR max by tomorrow and will be ready for review by then.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ydhandha"><img src="https://avatars.githubusercontent.com/u/69626304?v=4" />ydhandha</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Hi @eVoloshchak , PR is ready please check at your end.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/melvin-bot[bot]"><img src="https://avatars.githubusercontent.com/in/179547?v=4" />melvin-bot[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:</p> <ul> <li>when @ydhandha got assigned: 2023-09-07 21:31:21 Z</li> <li>when the PR got merged: 2023-09-17 23:52:45 UTC</li> <li>days elapsed: 6</li> </ul> <p>On to the next one 🚀</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/melvin-bot[bot]"><img src="https://avatars.githubusercontent.com/in/179547?v=4" />melvin-bot[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p><code>Reviewing</code> label has been removed, please complete the "BugZero Checklist".</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/melvin-bot[bot]"><img src="https://avatars.githubusercontent.com/in/179547?v=4" />melvin-bot[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.71-12 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:</p> <ul> <li><a href="https://github.com/Expensify/App/pull/27379">https://github.com/Expensify/App/pull/27379</a></li> </ul> <p>If no regressions arise, payment will be issued on 2023-09-27. :confetti_ball:</p> <p>After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.</p> <ul> <li>[ ] External issue reporter</li> <li>[ ] Contributor that fixed the issue</li> <li>[ ] Contributor+ that helped on the issue and/or PR</li> </ul> <p>For reference, here are some details about the assignees on this issue:</p> <ul> <li>@eVoloshchak <strong>does not</strong> require payment (Eligible for Manual Requests)</li> <li>@ydhandha requires payment</li> </ul> <p>As a reminder, here are the bonuses/penalties that should be applied for any External issue:</p> <ul> <li>Merged PR within 3 business days of assignment - 50% <strong>bonus</strong></li> <li>Merged PR more than 9 business days after assignment - 50% <strong>penalty</strong></li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/melvin-bot[bot]"><img src="https://avatars.githubusercontent.com/in/179547?v=4" />melvin-bot[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p><strong>BugZero Checklist:</strong> The PR fixing this issue has been merged! The following checklist (<a href="https://stackoverflow.com/c/expensify/questions/14574">instructions</a>) will need to be completed before the issue can be closed:</p> <ul> <li>[ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:</li> <li>[ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:</li> <li>[ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:</li> <li>[ ] [@eVoloshchak] Determine if we should create a regression test for this bug.</li> <li>[x] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the <a href="https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md">regression test</a> steps to ensure the same bug will not reach production again.</li> <li>[x] [@bfitzexpensify / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: <a href="https://github.com/Expensify/Expensify/issues/321481">https://github.com/Expensify/Expensify/issues/321481</a></li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Christinadobrzyn"><img src="https://avatars.githubusercontent.com/u/51066321?v=4" />Christinadobrzyn</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Looks like no speed bonus is applied here. </p> <p>@eVoloshchak should we have a regression test for this? </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/eVoloshchak"><img src="https://avatars.githubusercontent.com/u/9059945?v=4" />eVoloshchak</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <ul> <li>The PR that introduced the bug has been identified. Link to the PR: N/A, this is a bug in Chrome mobile</li> <li>The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A</li> <li>A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: it's a visual bug (screen glitching), don't think an additional discussion is needed</li> <li>Determine if we should create a regression test for this bug: I think we should, this is a bug in mobile Chrome, it's completely outside of our control, in theory it could come back at any point with a Chrome update</li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/eVoloshchak"><img src="https://avatars.githubusercontent.com/u/9059945?v=4" />eVoloshchak</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p><strong>Regression Test Proposal</strong></p> <p>(mobile Chrome only)</p> <ol> <li>Open Settings > Security > Two-Factor Authentication</li> <li>Copy Code and Press Next</li> <li>Input the code and verify that the password manager bar is not showing above the keyboard whilst adding/removing the code</li> <li>Input the code and verify there are no screen jumps/glitching whilst adding/removing the code</li> </ol> <p><strong>Do we agree 👍 or 👎</strong></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/JmillsExpensify"><img src="https://avatars.githubusercontent.com/u/1127863?v=4" />JmillsExpensify</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Can I get a payment summary for this issue? </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/bfitzexpensify"><img src="https://avatars.githubusercontent.com/u/38236554?v=4" />bfitzexpensify</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Sure: </p> <p>Contributor: @ydhandha $1000 to be paid via Upwork C+: @eVoloshchak $1000 to be paid via manual request</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/bfitzexpensify"><img src="https://avatars.githubusercontent.com/u/38236554?v=4" />bfitzexpensify</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>@ydhandha please apply <a href="https://www.upwork.com/jobs/~013b9960a030fc9144">here</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ydhandha"><img src="https://avatars.githubusercontent.com/u/69626304?v=4" />ydhandha</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>@bfitzexpensify, I have applied to the job link given. Please check and let me know if anything else is needed from my end!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Christinadobrzyn"><img src="https://avatars.githubusercontent.com/u/51066321?v=4" />Christinadobrzyn</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Hey @ydhandha I sent an offer to you, can you accept and I'll pay it out? Thanks!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ydhandha"><img src="https://avatars.githubusercontent.com/u/69626304?v=4" />ydhandha</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Hi @Christinadobrzyn, I have accepted the offer.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Christinadobrzyn"><img src="https://avatars.githubusercontent.com/u/51066321?v=4" />Christinadobrzyn</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Regression test GH: <a href="https://github.com/Expensify/Expensify/issues/321481">https://github.com/Expensify/Expensify/issues/321481</a></p> <p>Thanks @ydhandha! I paid you in Upwork based on this <a href="https://github.com/Expensify/App/issues/23575#issuecomment-1738873395">payment summary</a></p> <p>I think this is good to close? </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ydhandha"><img src="https://avatars.githubusercontent.com/u/69626304?v=4" />ydhandha</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Thanks @Christinadobrzyn. I can see the payment is done! </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/JmillsExpensify"><img src="https://avatars.githubusercontent.com/u/1127863?v=4" />JmillsExpensify</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>$1,000 payment for @eVoloshchak approved based on BZ summary. </p> </div> </div> <div class="page-bar-simple"> <a href="/Expensify/App/23575?page=1" class="previous">Previous</a> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

Expensify / App