search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[PAY TALHA] [HOLD for payment 2023-09-27] [$1000] ANDROID CHROME - Split Bill: LHN does not close if clicking on the Workspaces link #23810

Closed kavimuru closed 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to https://help.expensify.com/articles/playbooks/Expensify-Chat-Playbook-for-Conferences on mobile device.
  2. Open LHN and click on any step.
  3. Notice the LHN closes and page scrolls down to relevant section.
  4. Now go to https://help.expensify.com/hubs/split-bills.
  5. Open LHN and click on Workspaces.
  6. Notice the LHN does not close and nothing happens.

    Expected Result:

    In case of https://help.expensify.com/hubs/split-bill, clicking on links in the LHN which points to some section on the same page, the LHN should close and the screen should be scrolled down to relevant section.

    Actual Result:

    In case of https://help.expensify.com/hubs/split-bill, clicking on links in the LHN which points to some section on the same page, the LHN did not close.

Note: This seems to occur on the Workspaces link (the other 3 links seem fine).

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.47-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/887fc734-4577-4317-a9b3-2d1318d247c2

https://github.com/Expensify/App/assets/43996225/a6ccfad3-b76d-40d3-938a-8062b00f0263

Expensify/Expensify Issue URL: Issue reported by: @Talha345 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690460581911079

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b88583567474c0d1
  • Upwork Job ID: 1685897339918934016
  • Last Price Increase: 2023-09-11
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 26631441
    • Talha345 | Contributor | 26631442
    • Talha345 | Reporter | 26631443
tgolen commented 1 year ago

I'm OK with that proposal, but I think the extra function is unnecessary and the code can be simplified to not have isSamePageScrollLink(). I'll address that in the PR.

melvin-bot[bot] commented 1 year ago

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 1 year ago

📣 @Talha345 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] commented 1 year ago

📣 @Talha345 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

Talha345 commented 1 year ago

@tgolen Job accepted on upwork for the contributor role.Since I was the reporter for this issue, I got the reporter offer too but it is for $50 but this issue was reported way before the rates were updated, so I guess it should be $250, right? This discrepancy can be fixed either right now or once we get to the payments part but just wanted to mention for the record.

PR will be up in a few hours! 🚀

tgolen commented 1 year ago

Yeah, I agree with you that if it came before the rates were updated, then you get the original amount of $250. Let's handle that when this gets submitted for payment.

Talha345 commented 1 year ago

@tgolen @abdulrahuman5196 PR is ready for review https://github.com/Expensify/App/pull/27261

jliexpensify commented 1 year ago

@Talha345 I always post a payments summary before paying, so you can verify the rates then!

melvin-bot[bot] commented 1 year ago

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

On to the next one 🚀

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.71-12 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-27. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

jliexpensify commented 1 year ago

Payment Summary (is this right? It seems like it was merged in 3 days)

Is this correct?

New Upworks job.

Talha345 commented 1 year ago

Payment Summary (is this right? It seems like it was merged in 3 days)

  • Bug Reporter / Contributor: @Talha345 $250 + $1000 + $500 (speed bonus)
  • C+: @abdulrahuman5196: $1000 + $500 (speed bonus)

Is this correct?

New Upworks job.

@jliexpensify Looks correct! Do I have to apply to the new Upwork job or will you be sending an offer automatically?

jliexpensify commented 1 year ago

Offers have been sent!

Talha345 commented 1 year ago

Offers have been sent!

@jliexpensify Yes the offers were sent automatically on the old Upwork job and for this new Upwork job that you just linked, I simply got an invitation to submit a proposal but no offer.

jliexpensify commented 1 year ago

Reminder for @abdulrahuman5196 to complete the checklist

abdulrahuman5196 commented 1 year ago

The PR that introduced the bug has been identified. Link to the PR: The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. Seems to be the behaviour from beginning.

Determine if we should create a regression test for this bug. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. This is a minor case and wouldn't be beneficial to add tests.

abdulrahuman5196 commented 1 year ago

@jliexpensify Added checklist and submitted proposal on the upwork new job

jliexpensify commented 1 year ago

Thanks @abdulrahuman5196 have hired you, just waiting on acceptance

abdulrahuman5196 commented 1 year ago

@jliexpensify accepted the offer

jliexpensify commented 1 year ago

Paid out @abdulrahuman5196 - there was a very strange issue with your contract @Talha345 : can you confirm that you've not received any payment?

jliexpensify commented 1 year ago

@Talha345 I see you ended a contract today. This is a bit confusing - can I confirm if you have been paid?

Talha345 commented 1 year ago

Paid out @abdulrahuman5196 - there was a very strange issue with your contract @Talha345 : can you confirm that you've not received any payment?

@jliexpensify I have not received any payment, however I received a latest offer from you which I have accepted but I had now 3 different contracts for this same issue.

I have therefore ended the 2 previous contracts without any payment.Now you can pay me with the open contract.

jliexpensify commented 1 year ago

Thanks for clarifying - paid and job closed.