search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

[$1000] Web - Sidebar re-arrange on moving to report from split group #23905

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Split a bill
  2. Add 3 users
  3. Create the bill
  4. Observe the sidebar
  5. Click on the bill in the split group
  6. Click on any profile in split with section in the sidebar
  7. Select message [name]
  8. Observer the pattern
  9. You can repeat from step 5 for other users

Expected Result:

When clicking on any report, it's position in LHN should not change until data has been added to the compose box.

Actual Result:

The reports in LHN changes it's indexes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.47.3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/88d3a3e0-2931-44e7-b395-5e6f521ec8c1

https://github.com/Expensify/App/assets/93399543/eabdaf38-c31a-4015-be63-8f1f3b61be50

Expensify/Expensify Issue URL: Issue reported by: @krishna2323 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690663983822269

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01005e4b179e77b28f
  • Upwork Job ID: 1694361641774350336
  • Last Price Increase: 2023-08-23
pecanoro commented 1 year ago

Also the timestamp is updated from backend instead of using the sent lastVisibleActionCreated.

I checked this, it should come from the back-end indeed.

pecanoro commented 1 year ago

Ok, I think this is working as expected after checking with others, so I am going to close it.