Deploy Checklist: New Expensify 2023-08-03

OSBotify commented 1 year ago

Release Version: 1.3.50-0 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

[x] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[x] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
[x] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Beamanator commented 1 year ago

Oof we've got a lot of old PRs again 🙃 we can make a new section and check them off like last time (I'll help with that tomorrow morning)

OSBotify commented 1 year ago

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.50-0 :rocket:

mvtglobally commented 1 year ago

Beamanator commented 1 year ago

Checking off https://github.com/Expensify/App/issues/24123 since we marked in NAB

Beamanator commented 1 year ago

Checking off https://github.com/Expensify/App/issues/24131 b/c it was fixed & CP'd to staging 👍

Beamanator commented 1 year ago

Checking off https://github.com/Expensify/App/issues/24160 since it's related to "receipt scanning" which is under beta - but it still should be fixed soon

mvtglobally commented 1 year ago

Can you help with https://github.com/Expensify/App/pull/23648#issuecomment-1664422468

Beamanator commented 1 year ago

Yes @mvtglobally - i tested #23648 and checked it off b/c it's working well! 👍

mvtglobally commented 1 year ago

@Beamanator We are down to 2% TR left

Beamanator commented 1 year ago

Thanks for the update @mvtglobally ! I have to head out now for the weekend, I posted in internal channels, mentioning your update 👍 So someone else mayyy take this over this afternoon, but most likely we'll pick this back up on Monday 👍

Beamanator commented 1 year ago

Last note for the day:

this deploy blocker (https://github.com/Expensify/App/issues/24124) has a fix merged (https://github.com/Expensify/App/pull/24091) that is currently being CP'd to staging 👍

mvtglobally commented 1 year ago

@Beamanator We are down to 1% TR left

mvtglobally commented 1 year ago

Regression is completed

Current summary

[x] https://github.com/Expensify/App/pull/23636 is failing with https://github.com/Expensify/App/issues/23436
[x] https://github.com/Expensify/App/pull/23934 is failing https://github.com/Expensify/App/issues/24147
[x] https://github.com/Expensify/App/pull/23938 is failing https://github.com/Expensify/App/issues/24158
[x] https://github.com/Expensify/App/pull/23971 is failing https://github.com/Expensify/App/issues/24169
[x] https://github.com/Expensify/App/pull/23977 is pass on web/mWeb and blocked on the rest by https://github.com/Expensify/App/issues/23745

Beamanator commented 1 year ago

Checking https://github.com/Expensify/App/issues/24124 off since its fix is on staging 👍

Beamanator commented 1 year ago

Checking off https://github.com/Expensify/App/issues/24193 as we considered it a dupe

Checking off https://github.com/Expensify/App/issues/24147 b/c we CPd its fix (https://github.com/Expensify/App/pull/24203) to staging & it tested well, according to @MonilBhavsar

puneetlath commented 1 year ago

Checking off https://github.com/Expensify/App/issues/24183 as it's only occurring on dev so isn't a deploy blocker.

puneetlath commented 1 year ago

Checking off https://github.com/Expensify/App/pull/23934 based on this comment.

puneetlath commented 1 year ago

Checking off https://github.com/Expensify/App/pull/23938 since it was already there on production, so even if it isn't working, it's not a deploy blocker. I've asked the issue assignees to re-test.

puneetlath commented 1 year ago

Checking off https://github.com/Expensify/App/pull/23636 since it's not a deploy blocker. Commented in the PR so that they can address the fix not working.

puneetlath commented 1 year ago

Checking off https://github.com/Expensify/App/pull/23971. I tested it on web and iOS staging and it seems to be working as expected.

puneetlath commented 1 year ago

Checking off https://github.com/Expensify/App/pull/23977. I tested on iOS and it seems to be working.

puneetlath commented 1 year ago

:shipit:

Expensify / App

Deploy Checklist: New Expensify 2023-08-03 #24121