[HOLD - #25834] [$1000] Web - Chat - It takes a long time to reply to a Whisper message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to an account
2. Join a public room (one not used for conferences)
3. We will receive a Whisper message.
4. Hover over the Whisper and click "Reply in thread."
5. Click on the Chat header and select "Leave Thread."
6. Repeat step 4,5 few times
7. Observe that it takes a longer time to finish than usual.

Expected Result:

1. The function should response quickly
2. OR: the option to reply to a Whisper is redundant, we should hide it.

Actual Result:

1. It take a long time to response
2. During that loading time, it show Unavailable workspace

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: v1.3.53-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/f62d7a88-d8f6-4882-b8ed-bd4d6dba5108

https://github.com/Expensify/App/assets/115492554/a08ae339-beb0-4a15-994c-82cc3060ff09

Expensify/Expensify Issue URL:

Issue reported by: @tranvantoan-qn

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691093120525669

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0185bccf9578fe6b32
• Upwork Job ID: 1693686290700910592
• Last Price Increase: 2023-08-28

[melvin-bot[bot]]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Talha345]

Unable to reproduce. Seems to be working fine for me!

[alexpensify]

@tranvantoan-qn are you still able to reproduce it?

[tranvantoan-qn]

@alexpensify It seems a little bit faster when replying to Whisper's message, but the loading performance is pretty poor in general. I don't know if any recent changes have had an impact, but the app has been performing poorly for me in the few recent releases.

I've joined the public rooms:

• https://staging.new.expensify.com/r/5593084223054221

Sometimes the app becomes unresponsive.

https://github.com/Expensify/App/assets/10254571/3b8ffaac-8e38-40ca-b3a9-72c9695a6403

[alexpensify]

Ok thanks, I'll review this feedback

[alexpensify]

Still on my testing list

[melvin-bot[bot]]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alexpensify]

@techievivek - I need some feedback here. This 🐛 appears to be more performance-based and I couldn't find anything in the App repo that would address it. I know there are initiatives to improve performance but not sure if that will address this particular GH. Thanks for reviewing!

[alexpensify]

Not overdue, this one is still under review.

[techievivek]

@alexpensify

Something looks fishy here. For some reason we seem to be calling openReport twice for the same reportID. I inspected it a few times and it seems to behave the same way every time. The average openReport duration is somewhere between 700-800ms and that seems to be the case here as well but calling the command twice seems to have a delay effect? I think we can add the external label here to see if someone can figure out the reason.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0185bccf9578fe6b32

[melvin-bot[bot]]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[alexpensify]

Thanks @techievivek for the review! Adding the external label to keep moving forward.

[tranvantoan-qn]

I have a test account that performs extremely slowly - it makes the UI completely blocked. If you guys want to investigate more, maybe I can add you add a secondary contact, so you can login and check it

https://github.com/Expensify/App/assets/10254571/38062926-a5c7-47e1-acdc-d6c9e6dd332a

[alexpensify]

Thank you @tranvantoan-qn for that update

[tranvantoan-qn]

I would be pleased to assist in investigating the issue!

Btw, what @techievivek pointed out is also reported here: https://expensify.slack.com/archives/C049HHMV9SM/p1692661200803469

[melvin-bot[bot]]

@alexpensify @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[alexpensify]

@tranvantoan-qn - If you are interested in this issue, please submit a proposal for review. Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[alexpensify]

Still accepting proposals.

[alexpensify]

Waiting for proposals

[OlimpiaZurek]

Hi, I'm Olimpia from Callstack - expert contributor group. I’d like to work on this issue.

[michaelhaxhiu]

@OlimpiaZurek do you think we can group this GH and https://github.com/Expensify/App/issues/25834 into a single investigation and fix? Curious for your take as these are both performance-related.

If they don't feel similar enough in nature, feel free to express that sentiment and we can keep them separate.

[OlimpiaZurek]

@michaelhaxhiu Since both of these issues seem to be performance-related, I think we can group them together and investigate as a single issue.

[michaelhaxhiu]

cool 👍 let's do it, maybe you will need to coordinate with the internal engineer assigned on #25834 (Vivek) since that issue may pertain to backend performance. Let's see 👀

[alexpensify]

Alright with this feedback, I'm going to close this one in favor of https://github.com/Expensify/App/issues/25834

[tranvantoan-qn]

@alexpensify Am I eligible for reporting bonus? It seems like this is still a valid one and not a duplicate of #25834 (because it was created before that one).

[michaelhaxhiu]

@tranvantoan-qn you would be eligible for the reporting bonus after the bug is fixed only.

I think it may be wise to keep this GH open to track that this specific bug is fixed @alexpensify - this will help us track that it gets fixed for sure. There's a chance, for example, that the fix doesn't address this aspect of the problem (though I hope it does!)

[alexpensify]

@tranvantoan-qn - I'm OOO until tomorrow but will review your question when I'm back online.

[alexpensify]

With this feedback, I'm going to put this one on HOLD and update it to be a weekly.

[alexpensify]

Weekly Update: On hold

[alexpensify]

Weekly Update: On Hold

[alexpensify]

Weekly Update: On Hold

[alexpensify]

Weekly Update: On Hold

[alexpensify]

Weekly Update: On Hold

[alexpensify]

Weekly update: On Hold

[alexpensify]

Weekly Update: On Hold

[tranvantoan-qn]

@alexpensify

According to this message.

Can you help me to remove this link https://staging.new.expensify.com/r/5303403427249671 from the issue description above?

(Even though we do not need to send any message in this case)

[alexpensify]

Weekly update: On Hold but I edited the GH steps above.

[alexpensify]

Weekly Update: On Hold

[alexpensify]

Weekly Update: On Hold

[alexpensify]

Weekly Update: On Hold

[alexpensify]

@techievivek - The PR that we were on hold for was merged, are we good to take this one off hold and check it?

https://github.com/Expensify/Web-Expensify/pull/39587

[alexpensify]

Weekly Update: @techievivek any update here to my last question? Thanks!

[techievivek]

Sorry for the delay, I will test this and share the update. Thanks

[alexpensify]

Weekly update: Thank you @techievivek

[techievivek]

The performance issue seems to have been fixed. I did a live testing, and it seems to worked perfectly without any noticeable lag.

https://github.com/Expensify/App/assets/35863227/af8114b1-6a47-40c6-b8d9-617629c6dd3b

[tranvantoan-qn]

Can you determine if the reporting bonus is applicable to me? @alexpensify Thank you!