Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[HOLD for payment 2023-09-06] [TS migration] Migrate 'sizing.js' style to TypeScript #24691

Closed melvin-bot[bot] closed 1 year ago

melvin-bot[bot] commented 1 year ago

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/styles/utilities/sizing.js 0
JKobrynski commented 1 year ago

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

JKobrynski commented 1 year ago

The PR is ready for review!

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.58-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-06. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

@madmax330, @JKobrynski Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 1 year ago

@madmax330, @JKobrynski Eep! 4 days overdue now. Issues have feelings too...

madmax330 commented 1 year ago

Not overdue, PR was deployed to production, we can close