Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.9k forks source link

Attachment - Image does not zoom in when two fingers are used #2499

Closed isagoico closed 10 months ago

isagoico commented 3 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result

Confirm the image zooms in

Actual Result

Image does not zoom in

Action Performed

  1. Launch the app and login
  2. Send an image attachment
  3. After the attachment uploads, tap on it, confirm an attachment modal shows
  4. Use two fingers to zoom in

Platform

iOS ✔️ Android ✔️ mWeb/Chrome ✔️

Workaround:

User can zoom with double tap

Platform:

Where is this issue occurring?

Web iOS ✔️ Android ✔️ Desktop App Mobile Web

Version Number: 1.0.27-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Images/Videos Issue is reproducible in production but it's failing step 5 of this PR https://github.com/Expensify/Expensify.cash/pull/2442#issuecomment-823623629.

https://user-images.githubusercontent.com/44479856/115468224-c4c6e180-a200-11eb-8a4e-9e751b56a07f.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

NajiNazzal commented 1 year ago

Contributor details Your Expensify account email: najinazzal98@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01a352a7b4bf7c67cd

melvin-bot[bot] commented 1 year ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

melvin-bot[bot] commented 1 year ago

@isagoico, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

lanitochka17 commented 1 year ago

Issue is reproduced in build 1.3.83-1

https://github.com/Expensify/App/assets/78819774/b0eed716-fc8b-4823-ae64-994a527a2f3d

melvin-bot[bot] commented 10 months ago

@isagoico, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.