[$250] [HOLD for payment 2024-01-25] [TS migration] Migrate 'ConfirmModal.js' component to TypeScript

[melvin-bot[bot]]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/ConfirmModal.js	6

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010027c2a100ceaa28
• Upwork Job ID: 1750533235352903680
• Last Price Increase: 2024-01-25

[melvin-bot[bot]]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[JKobrynski]

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

[BartoszGrajdek]

This PR is no longer blocked! 😄 @JKobrynski

[JKobrynski]

@BartoszGrajdek unfortunately it's still blocked by ConfirmContent

[melvin-bot[bot]]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[blazejkustra]

unfortunately it's still blocked by ConfirmContent

Unblocked again! @JKobrynski

[JKobrynski]

The PR is ready for review!

[melvin-bot[bot]]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[MariaHCD]

Assigning @Ollyws for payment for C+ review.

[melvin-bot[bot]]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.26-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/33868

If no regressions arise, payment will be issued on 2024-01-25. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@Ollyws] Determine if we should create a regression test for this bug.
• [ ] [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~010027c2a100ceaa28

[melvin-bot[bot]]

Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new.

[sonialiap]

TS migration = $250

@Ollyws $250 - offer sent

[melvin-bot[bot]]

Upwork job price has been updated to $250

[Ollyws]

Accepted, thanks.

[sonialiap]

Paid ✔️