Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

[HOLD for payment 2024-01-04] [TS migration] Migrate 'PopoverWithoutOverlay' component to TypeScript #25051

Closed melvin-bot[bot] closed 10 months ago

melvin-bot[bot] commented 1 year ago

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/PopoverWithoutOverlay/index.js 10
Issue OwnerCurrent Issue Owner: @trjExpensify
melvin-bot[bot] commented 1 year ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

JKobrynski commented 1 year ago

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

BartoszGrajdek commented 11 months ago

This PR is no longer blocked! 😄 @JKobrynski

JKobrynski commented 11 months ago

@BartoszGrajdek I think it's still blocked by defaultProps and propTypes from Popover

melvin-bot[bot] commented 11 months ago

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

JKobrynski commented 11 months ago

The PR is ready for review!

melvin-bot[bot] commented 10 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 10 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.18-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-04. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 10 months ago

@mountiny, @JKobrynski, @situchan Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

mountiny commented 10 months ago

This is ready for payment @trjExpensify $250 to @situchan

trjExpensify commented 10 months ago

Sent an offer.

trjExpensify commented 10 months ago

Paid!