Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.34k stars 2.77k forks source link

[$250] [TS migration] Migrate 'CurrentUserPersonalDetailsSkeletonView' component to TypeScript #25052

Closed melvin-bot[bot] closed 9 months ago

melvin-bot[bot] commented 1 year ago

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/CurrentUserPersonalDetailsSkeletonView/index.js	10

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018e178b4e6783a7c9
Upwork Job ID: 1719458792094441472
Last Price Increase: 2023-11-02
Automatic offers:

mollfpr | Reviewer | 27462452

melvin-bot[bot] commented 1 year ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

JKobrynski commented 10 months ago

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

JKobrynski commented 10 months ago

The PR is ready for review!

melvin-bot[bot] commented 10 months ago

Job added to Upwork: https://www.upwork.com/jobs/~018e178b4e6783a7c9

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

melvin-bot[bot] commented 10 months ago

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

Christinadobrzyn commented 10 months ago

these jobs are $250 per https://expensify.slack.com/archives/C01SKUP7QR0/p1698944041595109

melvin-bot[bot] commented 10 months ago

Upwork job price has been updated to $250

melvin-bot[bot] commented 10 months ago

@mollfpr, @marcaaron, @JKobrynski Eep! 4 days overdue now. Issues have feelings too...

mollfpr commented 10 months ago

Not overdue, the PR looks good just need to complete the checklist and recordings.

mollfpr commented 10 months ago

The PR is merged.

melvin-bot[bot] commented 10 months ago

@mollfpr, @marcaaron, @JKobrynski Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 10 months ago

@mollfpr, @marcaaron, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 10 months ago

@mollfpr, @marcaaron, @JKobrynski Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 10 months ago

@mollfpr, @marcaaron, @JKobrynski 10 days overdue. Is anyone even seeing these? Hello?

mollfpr commented 10 months ago

Not overdue. The PR is in production. @Christinadobrzyn Could you help with the payment here later?

Screenshot 2023-11-21 at 21 46 40

melvin-bot[bot] commented 9 months ago

@mollfpr, @marcaaron, @JKobrynski Eep! 4 days overdue now. Issues have feelings too...

mollfpr commented 9 months ago

@marcaaron Could you help pull a BZ member here to proceed with the payment? Thank you!

melvin-bot[bot] commented 9 months ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 9 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

alexpensify commented 9 months ago

@marcaaron - to confirm, do we need to wait the 7-day period for regression and then complete the payment process? Thanks!

marcaaron commented 9 months ago

No need to wait.

I checked out the linked PR here and saw it has been on production for a while here.

And also saw in this issue that @mollfpr was not yet paid.

Christinadobrzyn commented 9 months ago

I'll grab this so we can get it paid. So sorry for the delay @mollfpr!

For some reason, the offer that was previously sent can't be modified so I sent you a new one in this Upwork job.

Payouts due:

Issue Reporter: NA Contributor: $250 @JKobrynski (Callstack so not paid through NewExpensify/Upwork) Contributor+: $250 @mollfpr (paid through NewExpensify)

Eligible for 50% #urgency bonus? NA - not for TS jobs

Upwork job is here. Internal job posting is here

alexpensify commented 9 months ago

Woo! Thanks @Christinadobrzyn for your help here.

JmillsExpensify commented 9 months ago

$250 payment approved for @mollfpr based on comment above.

Christinadobrzyn commented 9 months ago

awesome! closing!