[HOLD for payment 2024-01-26] [$250] [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript

[melvin-bot[bot]]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/MoneyReportHeader.js	20

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0152be230b0e427de5
• Upwork Job ID: 1736777290641367040
• Last Price Increase: 2023-12-18
• Automatic offers:
• KrAbhas | Contributor | 28064688

[melvin-bot[bot]]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot[bot]]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0152be230b0e427de5

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot[bot]]

⚠️ Failed to update price automatically. The BZ team member will need to update the price manually in Upwork.

[ishpaul777]

i would love to take it.

[KrAbhas]

I would like to work on this

[HezekielT]

I would like to work on this.

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript

What is the root cause of that problem?

Not problem (Technical ticket )

What changes do you think we should make in order to solve the problem?

We need to update this file using best practices using TS guide

https://github.com/Expensify/App/blob/main/contributingGuides/TS_STYLE.md

What alternative solutions did you explore? (Optional)

NA

[mananjadhav]

@KrAbhas is the first to comment with no other TS issue assigned.

🎀 👀 🎀 C+ reviewed.

[melvin-bot[bot]]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[yh-0218]

I would like to work on this issue

[melvin-bot[bot]]

📣 @KrAbhas 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[flodnv]

@KrAbhas when can we expect a PR? 🙏

[KrAbhas]

I am working on this, @flodnv, by today EOD, I'll raise the PR

[flodnv]

Great, thanks for the update!

On Fri, Dec 22, 2023 at 6:53 AM Abhas Kumar @.***> wrote:

I am working on this, @flodnv https://github.com/flodnv, by today EOD, I'll raise the PR

— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/25108#issuecomment-1867272731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7Y2OIDZEOGOHHCVS4OBD3YKUN7JAVCNFSM6AAAAAA3TGCR22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXGI3TENZTGE . You are receiving this because you were mentioned.Message ID: @.***>

[KrAbhas]

Almost done, just a few more hours.

[KrAbhas]

I have made the changes, raising PR after tests

[mananjadhav]

@KrAbhas Still waiting on the PR.

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @mananjadhav, @flodnv, @KrAbhas eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[flodnv]

Assuming we're done here. Please let me know if I'm wrong.

[mananjadhav]

@flodnv Payout is pending for my C+ role in PR review..

[flodnv]

Thanks, I wasn't sure, let's get that done

[flodnv]

If we didn't close the payment issue you would have gotten paid 😄 https://github.com/Expensify/App/issues/34484#issuecomment-1891052585

[mananjadhav]

It was a duplicate issue. I think @KrAbhas is also an external contributor. So they would have to be paid out too.

[flodnv]

@puneetlath since you were assigned to https://github.com/Expensify/App/issues/34484, assigning you here for payment 😄

[puneetlath]

Looks like we're still waiting on the regression period before paying this one.

[mananjadhav]

Yes but it looks like the automation failed. @puneetlath Can you update the issue title to reflect the held for payment and mention payout date?

[puneetlath]

Payment summary:

• Contributor - @KrAbhas - $250 (paid via Upwork)
• C+ - @mananjadhav - $250 (to be paid via NewDot)

Thanks everyone!

[JmillsExpensify]

$250 approved for @mananjadhav based on comment above.