[HOLD for payment 2024-03-20] [TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript

[melvin-bot[bot]]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/MoneyRequestConfirmationList.js	33

[melvin-bot[bot]]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot[bot]]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[kubabutkiewicz]

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

[melvin-bot[bot]]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[AndrewGable]

FYI this PR caused too many regressions and we are going to revert it. I'd be happy to review the next PR that addresses these issues.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.45-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/34168

If no regressions arise, payment will be issued on 2024-03-07. :confetti_ball:

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@AndrewGable] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[greg-schroeder]

Wait so this is still going to be reverted @AndrewGable? I saw it was deployed to prod anyway so I am a bit confused

[AndrewGable]

It was reverted and was not deployed

[melvin-bot[bot]]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[kubabutkiewicz]

@hoangzinh @AndrewGable PR is ready to check 😄

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.51-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/37716

If no regressions arise, payment will be issued on 2024-03-20. :confetti_ball:

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@AndrewGable] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot[bot]]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[greg-schroeder]

Apologies, I was OOO last week. Taking a look at this now!

[greg-schroeder]

Closing per https://github.com/Expensify/App/issues/25138#issuecomment-2010410827

[hoangzinh]

@greg-schroeder oh I was assigned to review the PR https://github.com/Expensify/App/pull/37716. Could you help to process a payment for me? Then we're fine to close it.

[greg-schroeder]

Sent you an offer

[hoangzinh]

@greg-schroeder Thanks. But TS migration usually has 250$ as a standard rate. Will you send another offer or will adjust the amount when payout?

[greg-schroeder]

@hoangzinh Ugh, I always forget to change it when I do custom offers (that's the default rate) - I've adjusted it.

[hoangzinh]

Accepted. Thanks @greg-schroeder