[HOLD for payment 2023-11-29] [$250] [TS migration] Migrate 'Modal' component to TypeScript

[melvin-bot[bot]]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/Modal/modalPropTypes.js	5
src/components/Modal/index.web.js	8
src/components/Modal/index.ios.js	4
src/components/Modal/index.android.js	4
src/components/Modal/BaseModal.js	12

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0197dfdc0abef354fc
• Upwork Job ID: 1722315062733119488
• Last Price Increase: 2023-11-28
• Automatic offers:
• situchan | Reviewer | 27580419

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot[bot]]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[JKobrynski]

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

[JKobrynski]

The PR is ready for review!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0197dfdc0abef354fc

[melvin-bot[bot]]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[mountiny]

PR is being reviewed

[melvin-bot[bot]]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

@mountiny, @JKobrynski, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[mountiny]

Has everything been covered for this issue? @JKobrynski ?

[melvin-bot[bot]]

@mountiny, @JKobrynski, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

Upwork job price has been updated to $250

[melvin-bot[bot]]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

$250 to @situchan for review and testing please cc @slafortune

[slafortune]

Paid 👍