Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.14k stars 2.64k forks source link

[HOLD for payment 2024-04-05] [TS migration] Migrate 'AttachmentCarousel' component to TypeScript #25152

Closed melvin-bot[bot] closed 3 months ago

melvin-bot[bot] commented 11 months ago

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/Attachments/AttachmentCarousel/useCarouselArrows.js 3
src/components/Attachments/AttachmentCarousel/index.native.js 11
src/components/Attachments/AttachmentCarousel/index.js 17
src/components/Attachments/AttachmentCarousel/extractAttachmentsFromReport.js 6
src/components/Attachments/AttachmentCarousel/attachmentCarouselPropTypes.js 3
src/components/Attachments/AttachmentCarousel/CarouselButtons.js 12
src/components/Attachments/AttachmentCarousel/CarouselActions.js 5
src/components/Attachments/AttachmentCarousel/Pager/index.js 9
src/components/Attachments/AttachmentCarousel/Pager/ImageWrapper.js 5
src/components/Attachments/AttachmentCarousel/Pager/ImageTransformer.js 8
src/components/Attachments/AttachmentCarousel/Pager/AttachmentCarouselPagerContext.js 1
src/components/Attachments/AttachmentCarousel/Pager/AttachmentCarouselPage.js 8
melvin-bot[bot] commented 10 months ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] commented 8 months ago

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

kubabutkiewicz commented 7 months ago

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

fabioh8010 commented 7 months ago

Updated List

Files

Path Dependencies
src/components/Attachments/AttachmentCarousel/useCarouselArrows.js 3
src/components/Attachments/AttachmentCarousel/index.native.js 19
src/components/Attachments/AttachmentCarousel/index.js 22
src/components/Attachments/AttachmentCarousel/extractAttachmentsFromReport.js 8
src/components/Attachments/AttachmentCarousel/attachmentCarouselPropTypes.js 4
src/components/Attachments/AttachmentCarousel/CarouselItem.js 13
src/components/Attachments/AttachmentCarousel/CarouselButtons.js 12
src/components/Attachments/AttachmentCarousel/CarouselActions.js 5
src/components/Attachments/AttachmentCarousel/AttachmentCarouselCellRenderer.js 5
src/components/Attachments/AttachmentCarousel/Pager/index.js 10
src/components/Attachments/AttachmentCarousel/Pager/ImageWrapper.js 5
src/components/Attachments/AttachmentCarousel/Pager/ImageTransformer.js 8
src/components/Attachments/AttachmentCarousel/Pager/AttachmentCarouselPagerContext.js 1
src/components/Attachments/AttachmentCarousel/Pager/AttachmentCarouselPage.js 8
melvin-bot[bot] commented 5 months ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

SzymczakJ commented 5 months ago

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 3 months ago

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

melvin-bot[bot] commented 3 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

s77rt commented 3 months ago

@puneetlath Can you please assign me here

melvin-bot[bot] commented 3 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.57-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

s77rt commented 3 months ago

No regression test needed since this is not a NewFeature

puneetlath commented 3 months ago

@s77rt offer here: https://www.upwork.com/nx/wm/offer/101735475

s77rt commented 3 months ago

@puneetlath Accepted! Thanks!

puneetlath commented 3 months ago

Paid, thanks everyone!