Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.44k stars 2.81k forks source link

[HOLD for payment 2024-03-07] [TS migration] Migrate 'HTMLRenderers' component to TypeScript #25154

Closed melvin-bot[bot] closed 7 months ago

melvin-bot[bot] commented 1 year ago

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/HTMLEngineProvider/HTMLRenderers/index.js	7
src/components/HTMLEngineProvider/HTMLRenderers/htmlRendererPropTypes.js	1
src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js	13
src/components/HTMLEngineProvider/HTMLRenderers/MentionHereRenderer.js	6
src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js	12
src/components/HTMLEngineProvider/HTMLRenderers/EditedRenderer.js	9
src/components/HTMLEngineProvider/HTMLRenderers/CodeRenderer.js	6
src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js	17
src/components/HTMLEngineProvider/HTMLRenderers/PreRenderer/index.native.js	4
src/components/HTMLEngineProvider/HTMLRenderers/PreRenderer/index.js	7
src/components/HTMLEngineProvider/HTMLRenderers/PreRenderer/BasePreRenderer.js	12

Issue Owner

Current Issue Owner: @laurenreidexpensify

melvin-bot[bot] commented 1 year ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] commented 10 months ago

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

ruben-rebelo commented 9 months ago

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

melvin-bot[bot] commented 9 months ago

📣 @ruben-rebelo! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:
```
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
```

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

mollfpr commented 8 months ago

@techievivek Could you assign me and add the BZ to the issue? Thanks!

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] commented 7 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 7 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

mollfpr commented 7 months ago

Both blocker seems already handled, but it is a regression from the TS refactor.

melvin-bot[bot] commented 7 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 7 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.40-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/35462

If no regressions arise, payment will be issued on 2024-02-20. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@mollfpr requires payment (Needs manual offer from BZ)
@ruben-rebelo does not require payment (Contractor)

melvin-bot[bot] commented 7 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[ ] [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

mollfpr commented 7 months ago

another regression https://github.com/Expensify/App/issues/36443

laurenreidexpensify commented 7 months ago

Not eligible for payment until regression is fixed

melvin-bot[bot] commented 7 months ago

Payment Summary

[Upwork Job]()

ROLE: @mollfpr paid $(AMOUNT) via Upwork (LINK)
Contributor: @ruben-rebelo is from an agency-contributor and not due payment

BugZero Checklist (@laurenreidexpensify)

[ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[ ] I have verified the payment summary above is correct

laurenreidexpensify commented 7 months ago

PR for regression in review - https://github.com/Expensify/App/pull/36998

laurenreidexpensify commented 7 months ago

regression PR in QA

techievivek commented 7 months ago

Not overdue, regression PR is merged and deployed to staging.

laurenreidexpensify commented 7 months ago

PR is on prod as of today 29.02.24 - payment now due 07.03.24

laurenreidexpensify commented 7 months ago

Payment due on Thurs

techievivek commented 7 months ago

Not overdue, payment will be done today. CC @laurenreidexpensify

laurenreidexpensify commented 7 months ago

Payment Summary:

C+ @mollfpr $250 offer sent via Upwork Contributor: @ruben-rebelo is from an agency-contributor and not due payment

laurenreidexpensify commented 7 months ago

https://www.upwork.com/jobs/~012d5a7a3432f9fa41

mollfpr commented 7 months ago

Thank you @laurenreidexpensify I'll do manual request in NewDot!

melvin-bot[bot] commented 7 months ago

Payment Summary

[Upwork Job]()

ROLE: @mollfpr paid $(AMOUNT) via Upwork (LINK)
Contributor: @ruben-rebelo is from an agency-contributor and not due payment

BugZero Checklist (@laurenreidexpensify)

[ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[ ] I have verified the payment summary above is correct

laurenreidexpensify commented 7 months ago

Payment Summary:

C+ @mollfpr $250 to be requested in newdot Contributor: @ruben-rebelo is from an agency-contributor and not due payment

JmillsExpensify commented 6 months ago

$250 approved for @mollfpr based on summary.