Closed melvin-bot[bot] closed 4 months ago
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
Path | Dependencies |
---|---|
src/pages/workspace/WorkspaceSettingsPage.js | 30 |
src/pages/workspace/WorkspaceSettingsCurrencyPage.js | 17 |
I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.
📣 @ruben-rebelo! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Triggered auto assignment to @isabelastisser (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
@isabelastisser could you please attach payment summary for review of https://github.com/Expensify/App/pull/34897
Awaiting payment summary.
Payment summary:
@ruben-rebelo $250 for PR review: https://github.com/Expensify/App/pull/34897 @rushatgabhane $250 for PR Review: https://github.com/Expensify/App/pull/34897
I believe you're missing @rushatgabhane from that payment summary.
Sorry about that, @JmillsExpensify! The payment summary is now updated.
$250 approved for @rushatgabhane
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files