Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.14k stars 2.64k forks source link

[TS migration] Migrate 'WorkspaceSettings' page to TypeScript #25191

Closed melvin-bot[bot] closed 4 months ago

melvin-bot[bot] commented 11 months ago

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/workspace/WorkspaceSettingsPage.js 26
melvin-bot[bot] commented 10 months ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] commented 8 months ago

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

fabioh8010 commented 7 months ago

Updated List

Files

Path Dependencies
src/pages/workspace/WorkspaceSettingsPage.js 30
src/pages/workspace/WorkspaceSettingsCurrencyPage.js 17
ruben-rebelo commented 6 months ago

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

melvin-bot[bot] commented 6 months ago

📣 @ruben-rebelo! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @isabelastisser (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] commented 4 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

rushatgabhane commented 4 months ago

@isabelastisser could you please attach payment summary for review of https://github.com/Expensify/App/pull/34897

JmillsExpensify commented 4 months ago

Awaiting payment summary.

isabelastisser commented 4 months ago

Payment summary:

@ruben-rebelo $250 for PR review: https://github.com/Expensify/App/pull/34897 @rushatgabhane $250 for PR Review: https://github.com/Expensify/App/pull/34897

JmillsExpensify commented 4 months ago

I believe you're missing @rushatgabhane from that payment summary.

isabelastisser commented 4 months ago

Sorry about that, @JmillsExpensify! The payment summary is now updated.

JmillsExpensify commented 3 months ago

$250 approved for @rushatgabhane