[HOLD for payment 2024-03-11] [TS migration] Migrate 'SettingsProfileDetails' page to TypeScript

[melvin-bot[bot]]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/pages/settings/Profile/PersonalDetails/PersonalDetailsInitialPage.js	18
src/pages/settings/Profile/PersonalDetails/LegalNamePage.js	21
src/pages/settings/Profile/PersonalDetails/DateOfBirthPage.js	20
src/pages/settings/Profile/PersonalDetails/AddressPage.js	24

[melvin-bot[bot]]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot[bot]]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[fabioh8010]

Updated List

Files

Path	Dependencies
src/pages/settings/Profile/PersonalDetails/PersonalDetailsInitialPage.js	19
src/pages/settings/Profile/PersonalDetails/LegalNamePage.js	23
src/pages/settings/Profile/PersonalDetails/DateOfBirthPage.js	20
src/pages/settings/Profile/PersonalDetails/CountrySelectionPage.js	12
src/pages/settings/Profile/PersonalDetails/AddressPage.js	15

[kubabutkiewicz]

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

[melvin-bot[bot]]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[melvin-bot[bot]]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot[bot]]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.46-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/37426

If no regressions arise, payment will be issued on 2024-03-11. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @kubabutkiewicz does not require payment (Contractor)

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@kubabutkiewicz] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[situchan]

@adelekennedy C+ payment is pending. I reviewed PR

[adelekennedy]

@situchan that's what I get for trusting the automatic comments 😅

[adelekennedy]

I just sent you an offer in Upwork, I'll pay it out once you accept!

[tylerkaraszewski]

Waiting for @situchan I believe, not overdue.

[adelekennedy]

actually my bad - I didn't get a notification you accepted the offer @situchan I just ended the contract and released payment