[$1000] Web - Settings - Unwanted behaviour when click on browser back button after clicking the report a bug

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

open the settings and go to about.
click on the report a bug, it goes to the concierge composer
Now, Click on the browser back button.
see the transitions occuring unpleasant to initial settings or about screen

Expected Result:

Either it should have only one transition to initial settings or about screen.

Actual Result:

it is giving the unpleasant transitions to initial settings or about screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.55-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/d2949841-f43a-4449-a4ae-e6dcd6fe9305

https://github.com/Expensify/App/assets/115492554/fd6c52dc-0b7d-4f67-99cd-4fd48686b53a

Expensify/Expensify Issue URL:

Issue reported by: @immadisetty-jaya-surya

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691135024865169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c4a8c2a8b4824bff
Upwork Job ID: 1692655236084695040
Last Price Increase: 2023-08-25

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

ShogunFire commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

When we click on report a bug and browser back button the transition is weird

What is the root cause of that problem?

We are not dismissing the about page from the stack when we go to the concierge chat here: https://github.com/Expensify/App/blob/e89ea9d73158ac395a411eca908733a681f598c8/src/pages/settings/AboutPage/AboutPage.js#L79

So when we click on the go back button it shows the about page briefly before going to the settings page

What changes do you think we should make in order to solve the problem?

We should use Navigation.dismissModal before navigating to concierge chat like this:

      translationKey: 'initialSettingsPage.aboutPage.reportABug',
      icon: Expensicons.Bug,
      action: () => {
          Navigation.dismissModal();
          Report.navigateToConciergeChat();
      },

Result:

https://github.com/Expensify/App/assets/19537677/523f1bf7-848a-4a95-b399-03cac95756e9

What alternative solutions did you explore? (Optional)

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~01c4a8c2a8b4824bff

melvin-bot[bot] commented 1 year ago

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

garrettmknight commented 1 year ago

Agreed that this looks like it should only pull up one menu and ideally the 'About' menu.

immadisetty-jaya-surya commented 1 year ago

@garrettmknight I have reported this issue, please update my username in the description so melvin can do automation, thanks

robertKozik commented 1 year ago

Hey @ShogunFire can you update your proposal per @garrettmknight comment ? So the about page would be available after the back action

ShogunFire commented 1 year ago

Actually after reading the slack conversation this issue like others should have been tagged with [Tracking Browser back button] and it should be resolved by this PR https://github.com/Expensify/App/pull/24165

I can't apply the patches so I still have the error but can someone try to reproduce after the patch ?

shubham1206agra commented 1 year ago

Hello everyone Temp logs

{
    "index": 1,
    "indexGetter": 1,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 2,
    "indexGetter": 2,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 3,
    "indexGetter": 3,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/r/7323501660300024",
            "id": "GhiTr-GpHH6SW8lA25iqS",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 3,
    "indexGetter": 3,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/r/7323501660300024",
            "id": "GhiTr-GpHH6SW8lA25iqS",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 2,
    "indexGetter": 2,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/r/7323501660300024",
            "id": "GhiTr-GpHH6SW8lA25iqS",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 2,
    "indexGetter": 2,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/r/7323501660300024",
            "id": "GhiTr-GpHH6SW8lA25iqS",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 1,
    "indexGetter": 1,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings",
            "id": "Ddpn6LV45RYRFw_ng7kjD",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}

adamgrzybowski commented 1 year ago

Hey, I am looking into this RN

WoLewicki commented 1 year ago

Could you check if it is still reproducible on the newest main @robertKozik and others? Seems like the issue is gone but maybe we are wrong.

robertKozik commented 1 year ago

On it 👀

robertKozik commented 1 year ago

Can confirm - I cannot reproduce this issue on latest main (video attached)

https://github.com/Expensify/App/assets/61146594/9796ecce-e687-4ff2-8103-32f97ca506d3

garrettmknight commented 1 year ago

Confirming it looks like it's been fixed. I'll still pay out @immadisetty-jaya-surya for reporting, but closing otherwise.

Summary of Payments:

Reporter - @immadisetty-jaya-surya - $250 paid in Upwork.

garrettmknight commented 1 year ago

Reopening - couldn't find the bug reporter's Upwork profile.

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

immadisetty-jaya-surya commented 1 year ago

@garrettmknight i m surya ...itz my upwork profile profile link : https://www.upwork.com/freelancers/~0126183a58ad2d5be4 inform me if it doesn't open .. thank you ... !!

garrettmknight commented 1 year ago

Thanks @immadisetty-jaya-surya - I can't seem to find you in the search on the job. Can you apply here so I can accept? https://www.upwork.com/jobs/~01c4a8c2a8b4824bff

immadisetty-jaya-surya commented 1 year ago

yeah @garrettmknight i applied which you have been send...!!

garrettmknight commented 1 year ago

Awesome, thanks! Offer sent.

immadisetty-jaya-surya commented 1 year ago

@garrettmknight Accepted the offer [:-)

garrettmknight commented 1 year ago

Nice, paid!

Expensify / App