search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

[HOLD for payment 2023-09-06] [$1000] Web - Split bill - Show more button in split bill has no padding below #25562

Closed izarutskaya closed 11 months ago

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open the app
  2. Click on plus and split bill
  3. Enter any amount and select more then 5 users
  4. After selecting users, click next, observe that show more button has no padding below making it look connected to split button
  5. Click on split
  6. Click on split bill message and observe that due to lack of padding below show more, it appears to be sticked to bottom of screen

Expected Result:

Show more button should have padding below like we generally have for all buttons to ensure they do not appear adjacent to any interface or bottom or screen

Actual Result:

Show more button has no padding below making it look adjacent to split button as well as bottom of screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.55-7

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/923fb9b2-98a1-4df1-b22d-325fa3cc515e

https://github.com/Expensify/App/assets/115492554/4e263b6b-694a-426b-985a-06f7b87571f3

Expensify/Expensify Issue URL:

Issue reported by: @Dhanashree-Sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691649933142409

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018d1ff6c61c186d88
  • Upwork Job ID: 1694384587884593152
  • Last Price Increase: 2023-08-23
  • Automatic offers:
    • Ollyws | Reviewer | 26307166
    • c3024 | Contributor | 26307169
    • Dhanashree-Sawant | Reporter | 26307172
JmillsExpensify commented 11 months ago

@Ollyws I see what happened now. We owed you $500. I accidentally you sent extra and request a portion of it back. Do you mind refunding that portion? Otherwise we are good here!

Ollyws commented 11 months ago

@JmillsExpensify I think about 15 minutes ago you paid me $2500? So I should return $1000 right?

Ollyws commented 11 months ago

returned $1000. Thanks!